Properly escape selected facets in search.html #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
jeancochrane
commented
Aug 20, 2020
| @@ -22,7 +22,7 @@ | |||
| 'opencivicdata>=3.1.0', | |||
| 'pytz>=2015.4', | |||
| 'django-haystack>=2.8.0,<2.9', | |||
| 'Django>=2.0,<2.2', | |||
| 'Django>=2.1,<2.2', | |||
There was a problem hiding this comment.
json_script was introduced in Django 2.1. How badly do we want to support Django 2.0.x? If we do, we can always copy the logic for json_script from the Django source and use that if the installed Django version is less than 2.1.
There was a problem hiding this comment.
I'm fine with bumping this to 2.1.x – Metro uses >= 2.2, and they're our power client.
hancush
approved these changes
Aug 20, 2020
| @@ -22,7 +22,7 @@ | |||
| 'opencivicdata>=3.1.0', | |||
| 'pytz>=2015.4', | |||
| 'django-haystack>=2.8.0,<2.9', | |||
| 'Django>=2.0,<2.2', | |||
| 'Django>=2.1,<2.2', | |||
There was a problem hiding this comment.
I'm fine with bumping this to 2.1.x – Metro uses >= 2.2, and they're our power client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR udpates
search/search.htmlto properly escape selected facets usingjson_script.Connects #270
Notes
This PR only fixes the bug in Councilmatic 2.5. Councilmatic 1.0 will have to be fixed separately.
Testing instructions