Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-4982 disable transaction manager for viewer #2576

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

devnaumov
Copy link
Member

No description provided.

@devnaumov devnaumov self-assigned this Apr 25, 2024
import { schema, schemaExtra } from '@cloudbeaver/core-utils';

const defaultSettings = schema.object({
'plugin.transaction-manager.disabled': schemaExtra.stringedBoolean().default(false),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use full plugin name plugin.datasource-transaction-manager.disabled

'plugin.transaction-manager.disabled': schemaExtra.stringedBoolean().default(false),
});

export type TransactionManagerSettingsSchema = typeof defaultSettings;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where do we need this type?
export type TransactionManagerSettingsSchema = typeof defaultSettings;

@devnaumov devnaumov requested a review from Wroud April 25, 2024 14:27
@Wroud Wroud merged commit 1bffe8a into devel Apr 26, 2024
4 checks passed
@Wroud Wroud deleted the CB-4982-transaction-manager-disabled branch April 26, 2024 13:49
DenisSinelnikov pushed a commit that referenced this pull request Apr 29, 2024
* CB-4982 disable transaction manager for viewer

* CB-4982 change naming

---------

Co-authored-by: kseniaguzeeva <112612526+kseniaguzeeva@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants