Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-4706 remove duplicated styles #2689

Merged
merged 4 commits into from
Jun 13, 2024
Merged

Conversation

devnaumov
Copy link
Member

No description provided.

@devnaumov devnaumov requested review from Wroud and sergeyteleshev June 5, 2024 16:28
@devnaumov devnaumov self-assigned this Jun 5, 2024
@sergeyteleshev sergeyteleshev changed the title CB-4705 remove duplicated styles CB-4706 remove duplicated styles Jun 6, 2024
@@ -8,6 +8,7 @@

.icon {
width: 100%;
height: 100%;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it's better to set max-height: 100% instead to avoid different bugs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

max-height: 100% will not work, please clarify which bugs you are referring to

@@ -9,9 +9,11 @@
.container {
display: flex;
width: 100%;
height: 100%;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

webapp/packages/plugin-react-data-grid/src/DataGrid.tsx Outdated Show resolved Hide resolved
webapp/packages/plugin-react-data-grid/src/index.ts Outdated Show resolved Hide resolved
@devnaumov devnaumov requested a review from Wroud June 12, 2024 13:41
@Wroud Wroud merged commit 1c9b4f1 into devel Jun 13, 2024
7 checks passed
@Wroud Wroud deleted the CB-4706-remove-dg-extra-styles branch June 13, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants