CB-4705 make data viewer model loaders more flexible #2690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeyteleshev
approved these changes
Jun 6, 2024
Wroud
requested changes
Jun 6, 2024
webapp/packages/plugin-data-viewer/src/DataViewerTableService.ts
Outdated
Show resolved
Hide resolved
webapp/packages/plugin-data-viewer/src/DataViewerTableService.ts
Outdated
Show resolved
Hide resolved
webapp/packages/plugin-data-viewer/src/DataViewerPage/useDataViewerPanel.ts
Outdated
Show resolved
Hide resolved
sergeyteleshev
approved these changes
Jun 7, 2024
| @@ -8,16 +8,17 @@ | |||
| import { observer } from 'mobx-react-lite'; | |||
| import { useCallback } from 'react'; | |||
|
|
|||
| import { Loader, TextPlaceholder } from '@cloudbeaver/core-blocks'; | |||
| import { Loader, TextPlaceholder, useAutoLoad, useTranslate } from '@cloudbeaver/core-blocks'; | |||
There was a problem hiding this comment.
pls remove unused loader here
|
|
||
| model = dataViewerTableService.create(connectionInfo, node); | ||
| tab.handlerState.tableId = model.id; | ||
| model.source.setOutdated(); |
There was a problem hiding this comment.
why do we need it to set it to outdated here? may be we should incapsulate this logic inside
dataViewerTableService.create() function?
There was a problem hiding this comment.
I think its better when create fn just create the model without any side effects
Wroud
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.