Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-6051 ability to download drivers #3155

Open
wants to merge 13 commits into
base: devel
Choose a base branch
from

Conversation

yagudin10
Copy link
Member

No description provided.

@devnaumov devnaumov marked this pull request as ready for review December 25, 2024 13:21
Comment on lines 22 to 23
width: 12px;
height: 12px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be we need a bit more larger icon? this one seems too small for me
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, If we expect users to hover over that icon, it's better to have it at least 14px or 16px. WCAG recommends minimum 24px, however in our case it's not a button and maybe not so critical, so we can make it smaller.
And I personally would place it on top. For users it will make more sense in terms of catching their attention since such approach is commonly used among many applications for different type of notifications.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I have a better Idea. Why don't we just make the whole driver icon hoverable? I assume this is how it should work. Icon itself doesn't need to be a target

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants