-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CB-6051 ability to download drivers #3155
base: devel
Are you sure you want to change the base?
CB-6051 ability to download drivers #3155
Conversation
…ownload-driver-from-the-maven-repository
…itory' of https://github.com/dbeaver/cloudbeaver into CB-6051-ability-to-download-driver-from-the-maven-repository
…-maven-repository
…ownload-driver-from-the-maven-repository
width: 12px; | ||
height: 12px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, If we expect users to hover over that icon, it's better to have it at least 14px or 16px. WCAG recommends minimum 24px, however in our case it's not a button and maybe not so critical, so we can make it smaller.
And I personally would place it on top. For users it will make more sense in terms of catching their attention since such approach is commonly used among many applications for different type of notifications.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I have a better Idea. Why don't we just make the whole driver icon hoverable? I assume this is how it should work. Icon itself doesn't need to be a target
…itory' of https://github.com/dbeaver/cloudbeaver into CB-6051-ability-to-download-driver-from-the-maven-repository
…-maven-repository
No description provided.