CB-5832 Add SQL editor shortcut to save script #3167
+182
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SychevAndrey
commented
Dec 30, 2024
SychevAndrey
commented
devnaumov
requested changes
Dec 30, 2024
| @@ -14,6 +21,7 @@ export default [ | |||
| ['sql_editor_shortcut_execute_script', 'Выполнить скрипт'], | |||
| ['sql_editor_shortcut_show_execution_plan', 'Показать план выполнения'], | |||
| ['sql_editor_shortcut_format', 'Форматировать скрипт'], | |||
| ['sql_editor_shortcut_save_as_script', 'Сохранить скрипт'], | |||
| @@ -189,6 +93,8 @@ export class PluginBootstrap extends Bootstrap { | |||
| }, | |||
| }); | |||
|
|
|||
| this.navigationTabsService.registerAction(ACTION_SAVE_AS_SCRIPT); | |||
There was a problem hiding this comment.
Please use SqlEditorView instead
| }); | ||
| } | ||
|
|
||
| private async saveAsScriptHandler(context: any, action: any) { |
There was a problem hiding this comment.
Please add types to context arg. Also no need to check and pass action type as we already know it from a method name. Check it only in handler above
…om:dbeaver/cloudbeaver into CB-5832-SQL-Editor-Shortcut-to-Save-script
devnaumov
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.