Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADAP-1124: Establish shared workflows for the monorepo migration #374

Closed
wants to merge 2 commits into from

Conversation

mikealfare
Copy link
Contributor

Problem

We're moving to a monorepo for adapters. This will require workflows that can be reused across adapters.

Solution

Migrate workflows from dbt-athena, which is already technically a monorepo (two packages) and make updates as needed to generalize. Update the workflows to support dbt-adapters and dbt-tests-adapter in the short term until their folder structures are updated, and then remove any existing workflows which are no longer necessary. Use this refactor as an opportunity to also clean up existing workflows which will live on in the monorepo.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Dec 6, 2024
@cla-bot cla-bot bot added the cla:yes The PR author has signed the CLA label Dec 6, 2024
Copy link

github-actions bot commented Dec 6, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@mikealfare mikealfare force-pushed the monorepo/common-workflows branch from f620f9f to bcaaa09 Compare December 6, 2024 23:11
@mikealfare
Copy link
Contributor Author

This was intended to show renamed files next to each other, but GH doesn't appear to be smart enough to interpret both a git mv and file updates and instead shows a deleted file and a new file instead.

@mikealfare mikealfare closed this Dec 6, 2024
@mikealfare mikealfare deleted the monorepo/common-workflows branch December 6, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes The PR author has signed the CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant