-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #10098 by undoing conditional agate
import in one place
#10103
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10103 +/- ##
==========================================
+ Coverage 88.18% 88.23% +0.05%
==========================================
Files 181 181
Lines 22759 22770 +11
==========================================
+ Hits 20069 20092 +23
+ Misses 2690 2678 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.8.latest 1.8.latest
# Navigate to the new working tree
cd .worktrees/backport-1.8.latest
# Create a new branch
git switch --create backport-10103-to-1.8.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fe9e39dab8df083b0e06b6392afbf97a01eda0e6
# Push it to GitHub
git push --set-upstream origin backport-10103-to-1.8.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.8.latest Then, create a pull request where the |
resolves #10098
Problem
Conditional import of
agate
forTYPE_CHECKING
is leading tomashumaro.exceptions.UnresolvedTypeReferenceError
duringRunResult.to_dict()
serializationSolution
Undo the conditional import for now, with a slight performance penalty.
Another approach could be to convert
results
fromList[RunResult]
toList[NodeResult]
before we stick them in the Jinja context here.For now, this is the safest & simplest way to restore the previous behavior.
Checklist