Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support complex types unit testing #9102

Closed
wants to merge 42 commits into from

Conversation

MichelleArk
Copy link
Contributor

resolves #

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

gshank and others added 28 commits August 14, 2023 16:04
Co-authored-by: Michelle Ark <michelle.ark@dbtlabs.com>
* WIP

* remove breakpoint

* fix tests, fix schema
* use unit test name as top level

* remove breakpoints

* finish converting tests

* fix unit test node name

* breakpoints

* fix partial parsing bug

* comment out duplicate test

* fix test and make unique id match other uniqu id patterns

* clean up

* fix incremental test

* Update tests/functional/unit_testing/test_unit_testing.py
* WIP

* adding tests

* fix tests

* more tests

* fix broken tests

* fix broken tests

* change to csv extension

* fix unit test yaml

* add mixed inline and file csv test

* add mixed inline and file csv test

* additional changes

* read file directly

* some cleanup and soem test fixes - wip

* fix test

* use better file searching

* fix final test

* cleanup

* use absolute path and fix tests
* Add unit tests to state:modified selection

* Get defer working too yolo

* Refactor per marky suggestion

* Add changelog

* separate out unit test state tests + fix csv fixture tests

* formatting

* detect changes to fixture files with state:modified

---------

Co-authored-by: Michelle Ark <michelle.ark@dbtlabs.com>
@cla-bot cla-bot bot added the cla:yes label Nov 15, 2023
@MichelleArk MichelleArk changed the base branch from main to unit_testing_feature_branch November 15, 2023 23:15
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

This comment was marked as outdated.

@MichelleArk MichelleArk force-pushed the support-complex-types-unit-testing branch from 7cc5a48 to 8197fa7 Compare November 21, 2023 20:05
* Switch to using 'test' command instead of 'unit-test'

* Remove old unit test

* Put daff changes into task/test.py

* changie

* test_type:unit

* Add unit test to build and make test

* Select test_type:data

* Add unit tets to test_graph_selector_methods.py

* Fix fqn to incude path components

* Update build test

* Remove part of message in test_csv_fixtures.py that's different on Windows

* Rename build test directory
@MichelleArk MichelleArk changed the title [spike] Support complex types unit testing support complex types unit testing Dec 4, 2023
@gshank gshank force-pushed the unit_testing_feature_branch branch 2 times, most recently from 8fbbb65 to 56dfb34 Compare January 2, 2024 22:53
Base automatically changed from unit_testing_feature_branch to main January 16, 2024 22:37
@MichelleArk
Copy link
Contributor Author

Closing in favor of: dbt-labs/dbt-adapters#55

although this bit may be useful for future work f1d68f4#diff-66cb1d60f7d296b4a5e8ca09de4e787a33bf6844dadc08ed7c1f1b1ddf62f97fR10-R13

@MichelleArk MichelleArk closed this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants