-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Redshift] Add tests for unit testing #680
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide. |
MichelleArk
force-pushed
the
adapter-unit-test-types
branch
from
December 4, 2023 08:06
1e2cf13
to
63c650c
Compare
…tTestInvalidInput
MichelleArk
changed the title
first pass: unit testing type tests
[Redshift] test types for unit testing
Feb 6, 2024
MichelleArk
changed the title
[Redshift] test types for unit testing
[Redshift] Add tests for unit testing
Feb 6, 2024
Merged
4 tasks
mikealfare
reviewed
Feb 7, 2024
mikealfare
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses: dbt-labs/dbt-core#9467
docs dbt-labs/docs.getdbt.com/#
Problem
Currently, the unit testing framework in core uses the safe_cast utils macro to convert a user-provided value for an input mock to the appropriate type. In some instances, this safe_cast may fail and need special handling depending on the type.
The acceptance criteria for this issue is to introduce a test that provides coverage across all primative input types (and arrays & objects if possible!) for unit testing input data, potentially updating the safe_cast macro as necessary.
Solution
Checklist