-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update job-scheduler.md #6676
Update job-scheduler.md #6676
Conversation
Coming newly into the orchestration team, I am updating the initial description of the scheduler types to better align with how users may view the product today: 1. we refer to merge jobs as merge jobs (and it is an explicit category in the UI) so I think it would be useful to call out that term in the beginning, so people associate that type of job with its name and 2. another event-based job is job completion (another explicit category in the UI) and I couldn't tell how that fit into the initial description, so added that as well. Feel free to revise, just wanted to flag those two points!
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -11,7 +11,8 @@ The job scheduler is the backbone of running jobs in dbt Cloud, bringing power a | |||
The scheduler enables both cron-based and event-driven execution of dbt commands in the user’s data platform. Specifically, it handles: | |||
|
|||
- Cron-based execution of dbt Cloud jobs that run on a predetermined cadence | |||
- Event-driven execution of dbt Cloud CI jobs triggered by pull requests to the dbt repo | |||
- Event-driven execution of dbt Cloud jobs that [run based on the completion of another job ([trigger on job completion](/docs/deploy/deploy-jobs#trigger-on-job-completion)) | |||
- Event-driven execution of dbt Cloud CI jobs triggered by pull requests to the dbt repo (e.g. "merge jobs") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[custom.LatinAbbreviations] Avoid Latin abbreviations: 'for example'. Consider using 'e.g' instead.
@@ -11,7 +11,8 @@ | |||
The scheduler enables both cron-based and event-driven execution of dbt commands in the user’s data platform. Specifically, it handles: | |||
|
|||
- Cron-based execution of dbt Cloud jobs that run on a predetermined cadence | |||
- Event-driven execution of dbt Cloud CI jobs triggered by pull requests to the dbt repo | |||
- Event-driven execution of dbt Cloud jobs that [run based on the completion of another job ([trigger on job completion](/docs/deploy/deploy-jobs#trigger-on-job-completion)) | |||
- Event-driven execution of dbt Cloud CI jobs triggered by pull requests to the dbt repo (e.g. "merge jobs") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[custom.Typos] Oops there's a typo -- did you really mean 'e.g.'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great suggestion @rcg798 ! really appreciate your contribution here and made a couple of small tweaks and merging for you!
Coming newly into the orchestration team, I am updating the initial description of the scheduler types to better align with how users may view the product today: 1. we refer to merge jobs as merge jobs (and it is an explicit category in the UI) so I think it would be useful to call out that term in the beginning, so people associate that type of job with its name and 2. another event-based job is job completion (another explicit category in the UI) and I couldn't tell how that fit into the initial description, so added that as well. Feel free to revise, just wanted to flag those two points! If it would be easier to flag this in Slack, let me know.
What are you changing in this pull request and why?
Checklist
🚀 Deployment available! Here are the direct links to the updated files: