Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add context about updated_at support #6746

Merged
merged 7 commits into from
Jan 9, 2025
Merged

Conversation

mirnawong1
Copy link
Contributor

@mirnawong1 mirnawong1 commented Jan 9, 2025

this pr adds what type the updated_at field of the timestamp strategy should have in relation to iso date strings and unix epoch integers.

Resolves # #1948


🚀 Deployment available! Here are the direct links to the updated files:

this pr adds what type the updated_at field of the timestamp strategy should have in relation to iso date strings and unix epoch integers.

Resolves # #1948
@mirnawong1 mirnawong1 requested a review from a team as a code owner January 9, 2025 14:48
Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Jan 9, 2025 5:27pm

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. Docs team Authored by the Docs team @dbt Labs labels Jan 9, 2025
website/docs/docs/build/snapshots.md Show resolved Hide resolved
website/docs/docs/build/snapshots.md Outdated Show resolved Hide resolved
website/docs/docs/build/snapshots.md Outdated Show resolved Hide resolved
website/docs/docs/build/snapshots.md Outdated Show resolved Hide resolved
website/docs/docs/build/snapshots.md Outdated Show resolved Hide resolved
@@ -80,7 +80,7 @@ The following table outlines the configurations available for snapshots:
| [strategy](/reference/resource-configs/strategy) | The snapshot strategy to use. Valid values: `timestamp` or `check` | Yes | timestamp |
| [unique_key](/reference/resource-configs/unique_key) | A <Term id="primary-key" /> column(s) (string or array) or expression for the record | Yes | `id` or `[order_id, product_id]` |
| [check_cols](/reference/resource-configs/check_cols) | If using the `check` strategy, then the columns to check | Only if using the `check` strategy | ["status"] |
| [updated_at](/reference/resource-configs/updated_at) | If using the `timestamp` strategy, the timestamp column to compare | Only if using the `timestamp` strategy | updated_at |
| [updated_at](/reference/resource-configs/updated_at) | If using the `timestamp` strategy, the timestamp column to compare. May support ISO date strings and unix epoch integers, depending on the data platform you use. | Only if using the `timestamp` strategy | updated_at |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @mirnawong1

This reads a bit funny to me. Should this read: "If using the timestamp strategy, the timestamp column will compare?"

Kind Regards

Copy link
Contributor Author

@mirnawong1 mirnawong1 Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eek that does read weird! how about:

A column in your snapshot query results that indicates when each record was last updated, used in the timestamp strategy.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's perfect.

Copy link
Contributor

@nataliefiann nataliefiann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @mirnawong1

Thanks for creating this PR. I've approved this for you and left a question.

Kind Regards
Natalie

@mirnawong1 mirnawong1 enabled auto-merge January 9, 2025 17:24
@mirnawong1 mirnawong1 merged commit 51b063f into current Jan 9, 2025
8 checks passed
@mirnawong1 mirnawong1 deleted the mirnawong1-patch-26 branch January 9, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants