Release of staging into main #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We still haven't implemented the full W-A-P flow yet so `staging` is behind `main`, fixing that and then we'll transition to the proper flow. --------- Co-authored-by: Winnie Winship <winnie@fishtownanalytics.com> Co-authored-by: dave-connors-3 <73915542+dave-connors-3@users.noreply.github.com>
Adds GHAs to call the Staging Deploy jobs for BQ and SF on merge to `staging`. This supports the change to make Staging the default branch in Jaffle Shop (already done), and completes the process of getting us to the following state: - 🌉 **Feature branches branch off Staging** - 🌅 **Feature branches are PR'd against Staging** and run CI jobs via API call across all active adapters (currently SF and BQ) in the Staging Environment - 🆕 **PRs are merged into Staging**, kicking off a CD build job in Staging (our default build command is `dbt build --exclude "resource_type:seed" because seeds are depended on as a source, and running a regular build will create a race condition where some models beat their source seeds into the warehouse and cause failing tests) - 🚀 **When we're ready for a Jaffle Shop Release we merge Staging into Main** kicking off CD jobs via API call in the Prod Environment across all active adapters - 🤓 **Dev Environments in dbt Cloud auto defer to Staging**, as we've set that up as a Staging Environment in Cloud --------- Co-authored-by: Winnie Winship <winnie@fishtownanalytics.com> Co-authored-by: dave-connors-3 <73915542+dave-connors-3@users.noreply.github.com>
This PR removes the seeds from the repo, opting for a flow that installs the [`jaffle-shop-generator`](https://github.com/dbt-labs/jaffle-shop-generator) in the project and generates data that way. This allows more data to be generated easily for more interesting Jaffle Shop projects with a longer lifespan, and future proofs the repo for updates to `jafgen` (if `jafgen` adds new entities and interactions, Jaffle Shop can build on them instead of being stuck with the old static seeds). This PR also fixes several data quality issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.