-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: dockerized deployment #386
Conversation
…own Docker development environment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks
I'll have a look why the test is broken, it seems like there's some problem with the DELA version... |
Yes, it relies on the latest dela with the new protocol names. |
since the reason the test is failing is not related to this PR, I think it can be merged @jbsv I'll let you hit the merge button |
Sorry, no, please don't merge. If you do, you put the dedis/d-voting repository in an unstable state. We first need to merge the dela-PR before this PR can be merged. @edit: didn't see that this goes into c4dt-main, sorry. But before we can merge it into main, dela needs to be updated with our changes. @jbsv hit merge, please! |
maybe I missed something, but how would this PR put the repository in an unstable state? it's only for a merge onto our branch ( also the CI for the tests is already broken on this branch |
@jbsv - just to make sure you saw the edit of my message above: please hit merge :) |
includes all the relevant files for the new dockerized deployment, including a helper script to set up/tear down a development environment