Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for the dkg public key after resharing #491

Closed
wants to merge 2 commits into from
Closed

Add check for the dkg public key after resharing #491

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7d708e
Add check if public key is the same after resharing to the same set o…
Jun 30, 2023
47fb4c5
Merge branch 'master' into master
AnomalRoil Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions share/dkg/pedersen/dkg_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,6 +668,10 @@ func TestDKGResharing(t *testing.T) {
newSecret, err := share.RecoverSecret(suite, newSShares, thr, defaultN)
require.NoError(t, err)
require.Equal(t, oldSecret.String(), newSecret.String())
// 3.
for i := 0; i < len(dkgs); i++ {
require.Equal(t, shares[i].Public(), newShares[i].Public())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the overall DKG public key should remain constant, not the public key of each share, right ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct, but the Public() method returns the public key of the distributed key:

kyber/share/dkg/pedersen/structs.go

Line 24 in a008b2d

// Public returns the public key associated with the distributed private key.

So this should pass.

}
}

// Test resharing functionality with one node less
Expand Down
Loading