Update button and data test id

deepfence · Jul 23, 2024 · e539a16 · e539a16
1 parent d6222e3
commit e539a16
Show file tree

Hide file tree

Showing 27 changed files with 49 additions and 28 deletions.
diff --git a/deepfence_frontend/apps/dashboard/src/features/malwares/pages/MalwareScanResults.tsx b/deepfence_frontend/apps/dashboard/src/features/malwares/pages/MalwareScanResults.tsx
@@ -1760,7 +1760,7 @@ const ScanResults = () => {
             onClick={() => {
               setFiltersExpanded((prev) => !prev);
             }}
-            id="filterTable"
+            data-testid="filterButtonIdForTable"
           >
             Filter
           </Button>

diff --git a/deepfence_frontend/apps/dashboard/src/features/malwares/pages/MalwareScans.tsx b/deepfence_frontend/apps/dashboard/src/features/malwares/pages/MalwareScans.tsx
@@ -1313,7 +1313,7 @@ const MalwareScans = () => {
             onClick={() => {
               setFiltersExpanded((prev) => !prev);
             }}
-            id="filterTable"
+            data-testid="filterButtonIdForTable"
           >
             Filter
           </Button>

diff --git a/deepfence_frontend/apps/dashboard/src/features/malwares/pages/MostExploitableMalwares.tsx b/deepfence_frontend/apps/dashboard/src/features/malwares/pages/MostExploitableMalwares.tsx
@@ -455,7 +455,7 @@ const MostExploitableMalwares = () => {
             onClick={() => {
               setFiltersExpanded((prev) => !prev);
             }}
-            id="filterTable"
+            data-testid="filterButtonIdForTable"
           >
             Filter
           </Button>

diff --git a/deepfence_frontend/apps/dashboard/src/features/malwares/pages/UniqueMalwares.tsx b/deepfence_frontend/apps/dashboard/src/features/malwares/pages/UniqueMalwares.tsx
@@ -490,7 +490,7 @@ const UniqueMalwares = () => {
             onClick={() => {
               setFiltersExpanded((prev) => !prev);
             }}
-            id="filterTable"
+            data-testid="filterButtonIdForTable"
           >
             Filter
           </Button>

diff --git a/...apps/dashboard/src/features/postures/components/scan-result/cloud/CloudPostureResults.tsx b/...apps/dashboard/src/features/postures/components/scan-result/cloud/CloudPostureResults.tsx
@@ -94,7 +94,7 @@ export const CloudPostureResults = () => {
             onClick={() => {
               setFiltersExpanded((prev) => !prev);
             }}
-            id="filterTable"
+            data-testid="filterButtonIdForTable"
           >
             Filter
           </Button>

diff --git a/...shboard/src/features/postures/components/scan-result/cloud/CloudPostureResultsGrouped.tsx b/...shboard/src/features/postures/components/scan-result/cloud/CloudPostureResultsGrouped.tsx
@@ -76,7 +76,7 @@ export const CloudPostureResultsGrouped = () => {
             onClick={() => {
               setFiltersExpanded((prev) => !prev);
             }}
-            id="filterTable"
+            data-testid="filterButtonIdForTable"
           >
             Filter
           </Button>

diff --git a/deepfence_frontend/apps/dashboard/src/features/postures/pages/Accounts.tsx b/deepfence_frontend/apps/dashboard/src/features/postures/pages/Accounts.tsx
@@ -1813,7 +1813,7 @@ const Accounts = () => {
             onClick={() => {
               setFiltersExpanded((prev) => !prev);
             }}
-            id="filterTable"
+            data-testid="filterButtonIdForTable"
           >
             Filter
           </Button>

diff --git a/deepfence_frontend/apps/dashboard/src/features/postures/pages/PostureScanResults.tsx b/deepfence_frontend/apps/dashboard/src/features/postures/pages/PostureScanResults.tsx
@@ -1305,7 +1305,7 @@ const PostureResults = () => {
             onClick={() => {
               setFiltersExpanded((prev) => !prev);
             }}
-            id="filterTable"
+            data-testid="filterButtonIdForTable"
           >
             Filter
           </Button>

diff --git a/deepfence_frontend/apps/dashboard/src/features/registries/pages/RegistryImageTags.tsx b/deepfence_frontend/apps/dashboard/src/features/registries/pages/RegistryImageTags.tsx
@@ -483,7 +483,7 @@ const RegistryImagesTagsResults = () => {
             onClick={() => {
               setFiltersExpanded((prev) => !prev);
             }}
-            id="filterTable"
+            data-testid="filterButtonIdForTable"
           >
             Filter
           </Button>

diff --git a/deepfence_frontend/apps/dashboard/src/features/secrets/pages/MostExploitableSecrets.tsx b/deepfence_frontend/apps/dashboard/src/features/secrets/pages/MostExploitableSecrets.tsx
@@ -436,7 +436,7 @@ const MostExploitableSecrets = () => {
             onClick={() => {
               setFiltersExpanded((prev) => !prev);
             }}
-            id="filterTable"
+            data-testid="filterButtonIdForTable"
           >
             Filter
           </Button>

diff --git a/deepfence_frontend/apps/dashboard/src/features/secrets/pages/SecretScanResults.tsx b/deepfence_frontend/apps/dashboard/src/features/secrets/pages/SecretScanResults.tsx
@@ -1737,7 +1737,7 @@ const ScanResults = () => {
             onClick={() => {
               setFiltersExpanded((prev) => !prev);
             }}
-            id="filterTable"
+            data-testid="filterButtonIdForTable"
           >
             Filter
           </Button>

diff --git a/deepfence_frontend/apps/dashboard/src/features/secrets/pages/SecretScans.tsx b/deepfence_frontend/apps/dashboard/src/features/secrets/pages/SecretScans.tsx
@@ -1308,7 +1308,7 @@ const SecretScans = () => {
             onClick={() => {
               setFiltersExpanded((prev) => !prev);
             }}
-            id="filterTable"
+            data-testid="filterButtonIdForTable"
           >
             Filter
           </Button>

diff --git a/deepfence_frontend/apps/dashboard/src/features/secrets/pages/UniqueSecrets.tsx b/deepfence_frontend/apps/dashboard/src/features/secrets/pages/UniqueSecrets.tsx
@@ -475,7 +475,7 @@ const UniqueSecrets = () => {
             onClick={() => {
               setFiltersExpanded((prev) => !prev);
             }}
-            id="filterTable"
+            data-testid="filterButtonIdForTable"
           >
             Filter
           </Button>

diff --git a/...ntend/apps/dashboard/src/features/topology/data-components/tables/CloudResourcesTable.tsx b/...ntend/apps/dashboard/src/features/topology/data-components/tables/CloudResourcesTable.tsx
@@ -78,7 +78,7 @@ export const CloudResourcesTable = () => {
           onClick={() => {
             setFiltersExpanded((prev) => !prev);
           }}
-          id="filterTable"
+          data-testid="filterButtonIdForTable"
         >
           Filter
         </Button>

diff --git a/..._frontend/apps/dashboard/src/features/topology/data-components/tables/ContainersTable.tsx b/..._frontend/apps/dashboard/src/features/topology/data-components/tables/ContainersTable.tsx
@@ -85,7 +85,7 @@ export const ContainersTable = () => {
           onClick={() => {
             setFiltersExpanded((prev) => !prev);
           }}
-          id="filterTable"
+          data-testid="filterButtonIdForTable"
         >
           Filter
         </Button>

diff --git a/...fence_frontend/apps/dashboard/src/features/topology/data-components/tables/HostsTable.tsx b/...fence_frontend/apps/dashboard/src/features/topology/data-components/tables/HostsTable.tsx
@@ -99,7 +99,7 @@ export const HostsTable = () => {
           onClick={() => {
             setFiltersExpanded((prev) => !prev);
           }}
-          id="filterTable"
+          data-testid="filterButtonIdForTable"
         >
           Filter
         </Button>

diff --git a/..._frontend/apps/dashboard/src/features/topology/data-components/tables/KubernetesTable.tsx b/..._frontend/apps/dashboard/src/features/topology/data-components/tables/KubernetesTable.tsx
@@ -203,7 +203,7 @@ export const KubernetesTable = () => {
           onClick={() => {
             setFiltersExpanded((prev) => !prev);
           }}
-          id="filterTable"
+          data-testid="filterButtonIdForTable"
         >
           Filter
         </Button>

diff --git a/deepfence_frontend/apps/dashboard/src/features/topology/data-components/tables/PodsTable.tsx b/deepfence_frontend/apps/dashboard/src/features/topology/data-components/tables/PodsTable.tsx
@@ -84,7 +84,7 @@ export const PodsTable = () => {
           onClick={() => {
             setFiltersExpanded((prev) => !prev);
           }}
-          id="filterTable"
+          data-testid="filterButtonIdForTable"
         >
           Filter
         </Button>

diff --git a/...tend/apps/dashboard/src/features/vulnerabilities/pages/MostExploitableVulnerabilities.tsx b/...tend/apps/dashboard/src/features/vulnerabilities/pages/MostExploitableVulnerabilities.tsx
@@ -690,7 +690,7 @@ const MostExploitableVulnerabilities = () => {
               onClick={() => {
                 setFiltersExpanded((prev) => !prev);
               }}
-              id="filterTable"
+              data-testid="filterButtonIdForTable"
             >
               Filter
             </Button>

diff --git a/deepfence_frontend/apps/dashboard/src/features/vulnerabilities/pages/RuntimeBom.tsx b/deepfence_frontend/apps/dashboard/src/features/vulnerabilities/pages/RuntimeBom.tsx
@@ -105,7 +105,7 @@ const RuntimeBom = () => {
             onClick={() => {
               setFiltersExpanded((prev) => !prev);
             }}
-            id="filterTable"
+            data-testid="filterButtonIdForTable"
           >
             Filter
           </Button>

diff --git a/...ence_frontend/apps/dashboard/src/features/vulnerabilities/pages/UniqueVulnerabilities.tsx b/...ence_frontend/apps/dashboard/src/features/vulnerabilities/pages/UniqueVulnerabilities.tsx
@@ -600,7 +600,7 @@ const UniqueVulnerabilities = () => {
             onClick={() => {
               setFiltersExpanded((prev) => !prev);
             }}
-            id="filterTable"
+            data-testid="filterButtonIdForTable"
           >
             Filter
           </Button>

diff --git a/...e_frontend/apps/dashboard/src/features/vulnerabilities/pages/VulnerabilityScanResults.tsx b/...e_frontend/apps/dashboard/src/features/vulnerabilities/pages/VulnerabilityScanResults.tsx
@@ -1685,7 +1685,7 @@ const CVEResults = () => {
             onClick={() => {
               setFiltersExpanded((prev) => !prev);
             }}
-            id="filterTable"
+            data-testid="filterButtonIdForTable"
           >
             Filter
           </Button>

diff --git a/deepfence_frontend/apps/dashboard/src/features/vulnerabilities/pages/VulnerabilityScans.tsx b/deepfence_frontend/apps/dashboard/src/features/vulnerabilities/pages/VulnerabilityScans.tsx
@@ -1369,7 +1369,7 @@ const VulnerabilityScans = () => {
             onClick={() => {
               setFiltersExpanded((prev) => !prev);
             }}
-            id="filterTable"
+            data-testid="filterButtonIdForTable"
           >
             Filter
           </Button>

diff --git a/deepfence_frontend/packages/ui-components/src/components/button/Button.test.tsx b/deepfence_frontend/packages/ui-components/src/components/button/Button.test.tsx
@@ -18,6 +18,7 @@ describe(`Component Button`, () => {
     const { getByTestId } = renderUI(
       <Button
         id="id"
+        data-testid="button-id"
         color="default"
         startIcon={<Plus />}
         endIcon={<Plus />}
@@ -39,6 +40,7 @@ describe(`Component Button`, () => {
     const { getByTestId, getByText } = renderUI(
       <Button
         id="id"
+        data-testid="button-id"
         color="default"
         startIcon={<Plus />}
         endIcon={<Plus />}

diff --git a/deepfence_frontend/packages/ui-components/src/components/button/Button.tsx b/deepfence_frontend/packages/ui-components/src/components/button/Button.tsx
@@ -432,7 +432,6 @@ const Button = React.forwardRef<HTMLButtonElement, ButtonProps>(
       <button
         ref={ref}
         id={_id}
-        data-testid={`button-${_id}`}
         disabled={disabled}
         className={cn(
           buttonCva({

diff --git a/deepfence_frontend/packages/ui-components/src/components/modal/Modal.test.tsx b/deepfence_frontend/packages/ui-components/src/components/modal/Modal.test.tsx
@@ -32,7 +32,12 @@ describe(`Component Modal`, () => {
 
       return (
         <>
-          <Button onClick={() => setOpen(true)} id="trigger-id" ref={ref}>
+          <Button
+            onClick={() => setOpen(true)}
+            id="trigger-id"
+            data-testid="button-trigger-id"
+            ref={ref}
+          >
             Click to open
           </Button>
           <Modal
@@ -79,7 +84,12 @@ describe(`Component Modal`, () => {
 
       return (
         <>
-          <Button onClick={() => setOpen(true)} id="trigger-id" ref={ref}>
+          <Button
+            onClick={() => setOpen(true)}
+            id="trigger-id"
+            data-testid="button-trigger-id"
+            ref={ref}
+          >
             Click to open
           </Button>
           <Modal

diff --git a/deepfence_frontend/packages/ui-components/src/components/modal/SlidingModal.test.tsx b/deepfence_frontend/packages/ui-components/src/components/modal/SlidingModal.test.tsx
@@ -33,7 +33,12 @@ describe(`Component SlidingModal`, () => {
       return (
         <>
           <div className="some-test">
-            <Button onClick={() => setOpen(true)} id="trigger-id" ref={ref}>
+            <Button
+              onClick={() => setOpen(true)}
+              id="trigger-id"
+              data-testid="button-trigger-id"
+              ref={ref}
+            >
               Click to open
             </Button>
           </div>
@@ -81,7 +86,12 @@ describe(`Component SlidingModal`, () => {
 
       return (
         <>
-          <Button onClick={() => setOpen(true)} id="trigger-id" ref={ref}>
+          <Button
+            onClick={() => setOpen(true)}
+            id="trigger-id"
+            data-testid="button-trigger-id"
+            ref={ref}
+          >
             Click to open
           </Button>
           <SlidingModal