Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test email feature in email configuration #2059

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Conversation

milan-deepfence
Copy link
Contributor

Fixes #1367

Changes proposed in this pull request:

  • Added test email button in email configurations
  • Update search configuration fields in configuration display

@milan-deepfence milan-deepfence requested a review from manV as a code owner April 3, 2024 13:03
Base automatically changed from ui-spec-update to main April 3, 2024 13:39
@manV manV self-requested a review April 4, 2024 11:31
@manV
Copy link
Member

manV commented Apr 4, 2024

@milan-deepfence @ibreakthecloud Clicking on "Send Test Email" Button should have same field validation in place as submit button. I don't think it is right UX to show just technical error for validation issues.
image

@milan-deepfence milan-deepfence merged commit 75eefc2 into main Apr 5, 2024
4 of 5 checks passed
@milan-deepfence milan-deepfence deleted the ui-feat-2048 branch April 5, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhancement: test SMTP / test integration buttons
2 participants