Replace string benchmark type with enum type #2179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manV
reviewed
Jun 5, 2024
deepfence_frontend/apps/dashboard/src/features/postures/pages/PostureCloudScanResults.tsx
Outdated
Show resolved
Hide resolved
manV
approved these changes
Jun 5, 2024
…ence/ThreatMapper into ui-fix-2199-enum-benchmark
* update specs and use spec enum * update api spec * Replace severities with enum api spec (#2156) * update to enum for severity references * update with api spec * added cloud service type api * reorder imports * Replace cloud provider string with enum (#2183) * wip enum update * remove unnecessary enum, rename function name * move enum to enum utils * Revert "move enum to enum utils" This reverts commit 10ae794. --------- Co-authored-by: Manan Vaghasiya <manan@ironmanan.com> --------- Co-authored-by: Manan Vaghasiya <manan@ironmanan.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/deepfence/enterprise-roadmap/issues/2199
Changes proposed in this pull request: