Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pretty name for applied filters, show warning modal in add email #2238

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Pretty name for applied filters, show warning modal in add email #2238

merged 2 commits into from
Jul 8, 2024

Conversation

milan-deepfence
Copy link
Contributor

Fixes #

Changes proposed in this pull request:

  • to show warning modal after send test email is clicked before submission of add email configuration
  • improve applied filters text to match selected items from dropdown

@milan-deepfence milan-deepfence requested a review from manV as a code owner July 5, 2024 14:05
@milan-deepfence milan-deepfence merged commit 0169dd9 into main Jul 8, 2024
4 of 5 checks passed
@milan-deepfence milan-deepfence deleted the ui-fix-improvements branch July 8, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manV manV manV approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milan-deepfence @manV