Optimize filter dropdowns #2393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icators - Added `open` and `setOpen` props to allow external control of the Combobox state. - Improved loading state handling to display a spinner when loading and no items are present. - Refactored conditional rendering for better clarity and performance.
…ding indicators - Added `isOpen` and `setIsOpen` props to `SearchableContainer` for better control of the component's visibility. - Enhanced loading state handling to differentiate between fetching and refetching states. - Updated the rendering logic to ensure proper display of the Combobox and its content based on the new state management.
- Updated SearchableHostList to utilize new ComboboxV2 components for improved UI and functionality. - Introduced debounced search functionality for better performance during host searches. - Removed onClearAll handlers from various components to streamline state management and reduce redundancy. - Enhanced loading state handling in SearchableHostList for a smoother user experience.
ramanan-ravi
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request: