test: reorganize docstore test suite to isolate dataframe tests #8684
+152
−106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
dataframe
field fromDocument
#8627Proposed Changes:
To initiate the removal of the
dataframe
field fromDocument
, the first step would be to remove its support across all Document Stores.Currently, most Document Stores test suites (in core-integrations) inherit from
DocumentStoreBaseTests
in Haystack.In this PR, I'm isolating dataframe filter tests by removing them from
FilterDocumentsTest
(a part ofDocumentStoreBaseTests
) and grouping them into a new utility class,FilterDocumentsTestWithDataframe
. This new class is not included inDocumentStoreBaseTests
.What will change after a Haystack release including this PR?
DocumentStoreBaseTests
orFilterDocumentsTest
won't automatically test Documents containingdataframe
.FilterDocumentsTestWithDataframe
.dataframe
support from Document Stores, avoiding the need to manually skip dataframe-specific test cases for each integration (a lot of manual work)How did you test it?
(CI)
Manually updated the
InMemoryDocumentStore
tests to inherit from bothFilterDocumentsTestWithDataframe
andDocumentStoreBaseTests
. All tests, including dataframe-related ones, executed as expected.Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
and added!
in case the PR includes breaking changes.