Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize gemspec and dependencies #37

Merged
merged 19 commits into from
Jun 17, 2024
Merged

Modernize gemspec and dependencies #37

merged 19 commits into from
Jun 17, 2024

Conversation

delano
Copy link
Owner

@delano delano commented Jun 17, 2024

This pull request includes several changes to modernize the gemspec and update dependencies.

  • Updated depdencencies:
    • yajl-ruby: Updated from ">= 0.1" to ">= 1.4.3".
    • oj: Remains unchanged at ">= 3.16.4".
    • redis: Added an upper limit, changing from ">= 4.0" to ">= 4.0", "< 5.0".
    • uri-redis: Version requirement raised from ">= 1.0.0" to ">= 1.3.0".

Also changed:

  • Re-write README.
  • Modernize the gemspec file.
  • Update the Redis port from 6371 to 6379.
  • Add a pre-commit configuration.
  • Use the latest Ruby CI overhaul.

These changes improve the codebase and ensure compatibility with the latest dependencies.

@delano delano self-assigned this Jun 17, 2024
@delano delano force-pushed the feature/34-update-dep-uri-redis branch from f4dcef6 to b2a07fe Compare June 17, 2024 20:05
@delano delano changed the title "Modernize gemspec and dependencies" Modernize gemspec and dependencies Jun 17, 2024
delano added 9 commits June 17, 2024 13:26
@delano
[#34] Fix for redis-rb 5 warning
3f716f4 
Redis#sadd will always return an Integer in Redis 5.0.0. Use Redis#sadd? instead
@delano
[#34] Additional debug logging
821e31e
@delano
[#34] Review and update tryouts
a6f3c03
@delano
[#34] Remove skipped tryout
7ed3a69
@delano
[#34] Fix race condition in Redis dump encoding test
359cdc2 
The test for base64 encoding of Redis dump values was sometimes failing
intermittently due to a race condition between inserting test values and
checking the encoding (I'm assuming since different ruby versions would
pass/fail each run). A short sleep was added before checking the encoded
values to avoid this race. Now the test is more reliable.
@delano
[#34] Improve debug logging for dump
212c776
@delano
[#34] Fix for redis-rb 5 warning in basic tryouts
c8d207c
@delano
[#34] Enable debug logging in tryouts
6357548
@delano
[#34] Update test case to check for array values
d77fbb6 
Without relying on the order the keys were returned in (e.g. `keys *`).
Redis does not guarantee the order of keys returned by `keys *`, so this
test case could fail if the keys are returned in a different order.
@delano delano merged commit d4d8275 into main Jun 17, 2024
5 checks passed
@delano delano deleted the feature/34-update-dep-uri-redis branch June 17, 2024 21:30
@delano delano mentioned this pull request Jun 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@delano delano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@delano