New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(lint): remove manual AST field counter #27449

Open

marvinhagemeister wants to merge 3 commits into main from lint_plugins_review

Contributor

marvinhagemeister commented Dec 22, 2024

Addresses the review feedback in #27416 .

Hoist the buffer max size variable to make it less confusing
Remove manual AST field counter in favour of an explicit "commit schema" step which writes the actual field count.

marvinhagemeister added 3 commits

December 22, 2024 20:51


          fix: hoist max size check

10f7224


          chore: infer prop count in schema

dc542e4


          chore: clippy

1c74e56

marvinhagemeister requested a review from dsherret

December 22, 2024 22:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet