Skip to content

Commit

Permalink
fix: github Action 브런치 제약구문 제거 및 코드 간소화
Browse files Browse the repository at this point in the history
- branches event trigger branch 네이밍 release로 수정
- type event trigger 추가 및 closed 정의
  • Loading branch information
Do-hyun-Kim committed Oct 17, 2024
1 parent 9ad25a1 commit 0e190a6
Showing 1 changed file with 10 additions and 3 deletions.
13 changes: 10 additions & 3 deletions .github/workflows/swift.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,10 @@ on:
- feat/*
- fix/*
pull_request:
types:
- closed
branches:
- release/**
- release
- develop

jobs:
Expand Down Expand Up @@ -61,7 +63,10 @@ jobs:
run: tuist generate

- name: fastlane upload_prd_testflight
if: github.event.pull_request.base.ref == 'release' && github.head_ref == 'develop'
if: >
github.event.pull_request.merged == true &&
github.event.pull_request.base.ref == 'release' &&
github.event.pull_request.head.ref == 'develop'
env:
APP_STORE_CONNECT_API_KEY_KEY_ID: ${{ secrets.APP_STORE_CONNECT_API_KEY_KEY_ID }}
APP_STORE_CONNECT_API_KEY_ISSUER_ID: ${{ secrets.APP_STORE_CONNECT_API_KEY_ISSUER_ID }}
Expand All @@ -82,7 +87,9 @@ jobs:


- name: fastlane upload_stg_testflight
if: github.event.pull_request.base.ref == 'develop' && startsWith(github.head_ref, 'feat/')
if: >
github.event.pull_request.merged == true &&
github.event.pull_request.base.ref == 'develop'
env:
APP_STORE_CONNECT_API_KEY_KEY_ID: ${{ secrets.APP_STORE_CONNECT_API_KEY_KEY_ID }}
APP_STORE_CONNECT_API_KEY_ISSUER_ID: ${{ secrets.APP_STORE_CONNECT_API_KEY_ISSUER_ID }}
Expand Down

0 comments on commit 0e190a6

Please sign in to comment.