Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release #739

Merged
merged 2 commits into from
Dec 29, 2024
Merged

Release #739

merged 2 commits into from
Dec 29, 2024

Conversation

Do-hyun-Kim
Copy link
Collaborator

πŸ”΅PR을 올리기 μ „ μ•„λž˜ 사항을 ν™•μΈν•΄μ£Όμ„Έμš”.

  • κ΅¬ν˜„ν•œ 둜직과 κΈ°λŠ₯이 μ˜¬λ°”λ₯΄κ²Œ μž‘λ™λ˜λŠ”μ§€ μΆ©λΆ„νžˆ ν…ŒμŠ€νŠΈν•΄μ£Όμ„Έμš”.
  • μ½”λ“œμ˜ μ„±λŠ₯μ΄λ‚˜ λ©”λͺ¨λ¦¬ νš¨μœ¨μ„±μ΄ μ μ ˆν•˜κ²Œ κ³ λ €λ˜μ—ˆλŠ”μ§€, λΆˆν•„μš”ν•œ μ½”λ“œκ°€ μ—†λŠ”μ§€ κ²€ν† ν•΄μ£Όμ„Έμš”.
  • 이번 PRμ—μ„œ κ΅¬ν˜„λœ μ£Όμš” κΈ°λŠ₯μ΄λ‚˜ ν•΄κ²°λœ λ¬Έμ œμ— λŒ€ν•΄ μžμ„Ένžˆ μ„œμˆ ν•΄μ£Όμ„Έμš”.
    (μœ„ λ‚΄μš©μ€ μ§€μ›Œμ£Όμ„Έμš”)

πŸ˜½κ°œμš”

  • (μž‘μ—…ν•œ μ½”λ“œμ— λŒ€ν•œ κ°„λž΅ν•œ μ„€λͺ…ν•΄μ£Όμ„Έμš”)

πŸ› οΈμž‘μ—… λ‚΄μš©

(μ†Œμ œλͺ©)

  • (μž‘μ—…ν•œ μ½”λ“œμ— λŒ€ν•œ μžμ„Έν•œ μ„€λͺ…ν•΄μ£Όμ„Έμš”. ν•„μš”ν•˜λ‹€λ©΄ μ΄λ―Έμ§€λ‚˜ ν‘œλ₯Ό μ²¨λΆ€ν•΄μ£Όμ„Έμš”)
이미지①

(μ†Œμ œλͺ©)

  • (μž‘μ—…ν•œ μ½”λ“œμ— λŒ€ν•œ μžμ„Έν•œ μ„€λͺ…ν•΄μ£Όμ„Έμš”. ν•„μš”ν•˜λ‹€λ©΄ μ΄λ―Έμ§€λ‚˜ ν‘œλ₯Ό μ²¨λΆ€ν•΄μ£Όμ„Έμš”)
이미지①

πŸŸ‘μ°¨ν›„ κ³„νš (Optional)

  • (μž‘μ—…ν•œ μ½”λ“œκ°€ μΆ”ν›„ 우리 ν”„λ‘œμ νŠΈμ— μ–΄λ–€ 영ν–₯을 끼칠지, μ•žμœΌλ‘œ PRκ³„νšμ„ μ„€λͺ…ν•΄μ£Όμ„Έμš”)

πŸ—Ύμ΄λ―Έμ§€ (Optional)

이미지①

βœ…ν…ŒμŠ€νŠΈ μΌ€μ΄μŠ€

  • (κ΅¬ν˜„ν•œ 둜직 검증을 μœ„ν•΄ ν…ŒμŠ€νŠΈν•œ λ‚΄μš©μ„ μ„€λͺ…ν•΄μ£Όμ„Έμš”)

πŸ™πŸ»μ•„λž˜μ™€ 같이 PR을 λ¦¬λ·°ν•΄μ£Όμ„Έμš”.

  • PR λ‚΄μš©μ΄ λΆ€μ‘±ν•˜λ‹€λ©΄ 보좩 μš”μ²­ν•΄μ£Όμ„Έμš”.
  • μ½”λ“œ μŠ€νƒ€μΌμ΄ νŒ€μ˜ κ·œμΉ™μ— 맞게 μž‘μ„±λ˜μ—ˆλŠ”μ§€, 일관성을 μœ μ§€ν•˜κ³  μžˆλŠ”μ§€ ν™•μΈν•΄μ£Όμ„Έμš”.
  • μ½”λ“œμ— λŒ€ν•œ λ¬Έμ„œν™”λ‚˜ 주석이 ν•„μš”ν•œ 뢀뢄에 μ μ ˆν•˜κ²Œ μž‘μ„±λ˜μ–΄ μžˆλŠ”μ§€ ν™•μΈν•΄μ£Όμ„Έμš”.
  • κ΅¬ν˜„λœ 둜직이 효율적이고 μ˜¬λ°”λ₯΄κ²Œ μž‘μ„±λ˜μ—ˆλŠ”μ§€, μ•„ν‚€ν…μ²˜λ₯Ό 잘 μ€€μˆ˜ν•˜κ³  μžˆλŠ”μ§€ κ²€ν† ν•΄μ£Όμ„Έμš”.
  • 넀이밍, ν¬λ§€νŒ…, 주석 λ“± μ½”λ“œμ˜ 일관성이 μœ μ§€λ˜κ³  μžˆλŠ”μ§€ ν™•μΈν•΄μ£Όμ„Έμš”.

@Do-hyun-Kim Do-hyun-Kim merged commit fae4f9f into develop Dec 29, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant