refactor: Feedback compareTo 메소드를 Comparator 사용으로 변경한다

depromeet · Mar 9, 2024 · 709a886 · 709a886
1 parent a72fa11
commit 709a886
Showing 1 changed file with 6 additions and 13 deletions.
diff --git a/src/main/kotlin/me/nalab/api/survey/domain/feedback/Feedback.kt b/src/main/kotlin/me/nalab/api/survey/domain/feedback/Feedback.kt
@@ -29,18 +29,11 @@ class Feedback(
 ) : Comparable<Feedback>, TimeBaseEntity() {
 
     override fun compareTo(other: Feedback): Int {
-        if (updatedAt.isAfter(other.updatedAt)) {
-            return -1
-        }
-        if (updatedAt.isBefore(other.updatedAt)) {
-            return 1
-        }
-        if (createdAt.isAfter(other.createdAt)) {
-            return -1
-        }
-        if (createdAt.isBefore(other.createdAt)) {
-            return 1
-        }
-        return 0
+        return DEFAULT_COMPARATOR.compare(this, other);
+    }
+
+    companion object {
+        val DEFAULT_COMPARATOR =
+            compareByDescending<Feedback> { it.updatedAt }.thenByDescending { it.createdAt }
     }
 }