Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release]: 중복 survey생성을 막는다 #386

Merged
merged 6 commits into from
Mar 6, 2024
Merged

[release]: 중복 survey생성을 막는다 #386

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7bb89f7
perf: Survey.targetId에 unique index를 추가한다
devxb Mar 6, 2024
5fc2e04
refactor: Survey 생성시 이미 존재하는 survey가 있다면 예외를 던진다.
devxb Mar 6, 2024
3200ead
feat: DuplicateSurveyException 핸들러를 추가한다
devxb Mar 6, 2024
48ea22e
test: Survey가 중복등록되었을때, 예외를 던지는 테스트를 추가한다
devxb Mar 6, 2024
9967ab1
test: hurl 테스트에서 유저가 중복되어서 테스트가 실패하는 버그를 수정한다
devxb Mar 6, 2024
b6da2d0
test: hurl feedback_find.hurl의 이메일이 겹치는 버그를 수정한다
devxb Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions api/src/main/resources/db/migration/v11_survey_unique_index_target.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
create unique index survey_idx_target_id on survey(target_id)
2 changes: 1 addition & 1 deletion core/data/src/main/java/me/nalab/core/data/survey/SurveyEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public class SurveyEntity extends TimeBaseEntity {
@OneToMany(mappedBy = "survey", fetch = FetchType.LAZY, cascade = {CascadeType.PERSIST, CascadeType.MERGE})
private List<FormQuestionEntity> formQuestionableList;

@JoinColumn(name = "target_id", nullable = false)
@JoinColumn(name = "target_id", nullable = false, unique = true)
private Long targetId;

SurveyEntity(SurveyEntityBuilder<?, ?> surveyEntityBuilder){
Expand Down
Loading