Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] : bookmark 카운트가 bookmark한 대상에게 증가하는 버그 수정 #399

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

devxb
Copy link
Member

@devxb devxb commented Mar 7, 2024

어떤 기능을 개발했나요?

북마크를 누른 대상의 북마크된 카운트 가 증가하는 버그를 수정했습니다.

어떻게 해결했나요?

  • 북마크 / 북마크 취소 여부에 상관없이 숫자가 감소 증가하는 버그 수정
  • 북마크 당한 대상의 북마크 카운트 증가하도록 수정

참고자료

@devxb devxb requested a review from dojinyou March 7, 2024 10:47
Copy link
Member

@dojinyou dojinyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

개인적으로는 어플리케이션에서 호출 여부 결정하고 도메인 콜하는게 좋아보이긴 함!
그러면 얼리리턴하고 코드 깔끔할듯? 근데 지금도 큰 문제는 없으니

@devxb
Copy link
Member Author

devxb commented Mar 7, 2024

로컬에서 한번 바꿔봤는데, 아래처럼 도메인로직이 밖으로 빠지는 느낌이라 일단 킵 할께

스크린샷 2024-03-07 오후 8 05 52

@devxb devxb merged commit 2c5eecd into release Mar 7, 2024
3 checks passed
@devxb devxb deleted the devxb/hotfix-bookmark branch March 7, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants