♻️ refactor(domain): change name announcement -> notice (#493)

* ♻️ refactor(domain): change name announcement -> notice * ♻️ refactor(api): change name announcement -> notice * ♻️ refactor(admin): change name announcement -> notice
depromeet · Jul 4, 2024 · b1425a0 · b1425a0
1 parent 687ae99
commit b1425a0
Show file tree

Hide file tree

Showing 9 changed files with 34 additions and 32 deletions.
diff --git a/...r/src/main/java/com/depromeet/domains/announcement/repository/AnnouncementRepository.java b/...r/src/main/java/com/depromeet/domains/announcement/repository/AnnouncementRepository.java
@@ -1,11 +1,11 @@
 package com.depromeet.domains.announcement.repository;
 
-import com.depromeet.announcement.Announcement;
+import com.depromeet.notice.Notice;
 import org.springframework.data.domain.Page;
 import org.springframework.data.domain.Pageable;
 import org.springframework.data.jpa.repository.JpaRepository;
 
-public interface AnnouncementRepository extends JpaRepository<Announcement, Long> {
+public interface AnnouncementRepository extends JpaRepository<Notice, Long> {
 
-    Page<Announcement> findAll(Pageable pageable);
+    Page<Notice> findAll(Pageable pageable);
 }
diff --git a/...-server/src/main/java/com/depromeet/domains/announcement/service/AnnouncementService.java b/...-server/src/main/java/com/depromeet/domains/announcement/service/AnnouncementService.java
@@ -1,6 +1,6 @@
 package com.depromeet.domains.announcement.service;
 
-import com.depromeet.announcement.Announcement;
+import com.depromeet.notice.Notice;
 import com.depromeet.common.dto.PageMetaData;
 import com.depromeet.common.dto.PageResponseDto;
 import com.depromeet.domains.announcement.dto.request.AnnouncementRequestDto;
@@ -60,9 +60,9 @@ public AnnouncementResponseDto getAnnouncement(Long announcementId) {
 
     public AnnouncementResponseDto createAnnouncement(AnnouncementRequestDto requestDto) {
 
-        Announcement announcement = new Announcement(requestDto.getTitle(), requestDto.getContent());
+        Notice notice = new Notice(requestDto.getTitle(), requestDto.getContent());
 
-        var announcementResult = announcementRepository.save(announcement);
+        var announcementResult = announcementRepository.save(notice);
         return AnnouncementResponseDto.builder()
                 .id(announcementResult.getId())
                 .title(announcementResult.getTitle())

diff --git a/...op-api/src/main/java/com/depromeet/domains/notice/dto/response/NoticeListResponseDto.java b/...op-api/src/main/java/com/depromeet/domains/notice/dto/response/NoticeListResponseDto.java
@@ -1,6 +1,6 @@
 package com.depromeet.domains.notice.dto.response;
 
-import com.depromeet.announcement.Announcement;
+import com.depromeet.notice.Notice;
 import io.swagger.v3.oas.annotations.media.Schema;
 
 import java.time.LocalDateTime;
@@ -15,11 +15,11 @@ public record NoticeListResponseDto(
         @Schema(description = "생성시간", example = "yyyy-MM-dd HH:mm:ss")
         LocalDateTime createdAt
 ) {
-    public NoticeListResponseDto(Announcement announcement) {
+    public NoticeListResponseDto(Notice notice) {
         this(
-                announcement.getId(),
-                announcement.getTitle(),
-                announcement.getCreatedAt()
+                notice.getId(),
+                notice.getTitle(),
+                notice.getCreatedAt()
         );
     }
 }
diff --git a/...etdrop-api/src/main/java/com/depromeet/domains/notice/dto/response/NoticeResponseDto.java b/...etdrop-api/src/main/java/com/depromeet/domains/notice/dto/response/NoticeResponseDto.java
@@ -1,6 +1,6 @@
 package com.depromeet.domains.notice.dto.response;
 
-import com.depromeet.announcement.Announcement;
+import com.depromeet.notice.Notice;
 import io.swagger.v3.oas.annotations.media.Schema;
 import java.time.LocalDateTime;
 
@@ -17,12 +17,12 @@ public record NoticeResponseDto(
         @Schema(description = "생성시간", example = "yyyy-MM-dd HH:mm:ss")
         LocalDateTime createdAt
 ) {
-    public NoticeResponseDto(Announcement announcement) {
+    public NoticeResponseDto(Notice notice) {
         this(
-                announcement.getId(),
-                announcement.getTitle(),
-                announcement.getContent(),
-                announcement.getCreatedAt()
+                notice.getId(),
+                notice.getTitle(),
+                notice.getContent(),
+                notice.getCreatedAt()
         );
     }
 }
diff --git a/...treetdrop-api/src/main/java/com/depromeet/domains/notice/repository/NoticeRepository.java b/...treetdrop-api/src/main/java/com/depromeet/domains/notice/repository/NoticeRepository.java
@@ -1,9 +1,9 @@
 package com.depromeet.domains.notice.repository;
 
-import com.depromeet.announcement.Announcement;
+import com.depromeet.notice.Notice;
 import org.springframework.data.jpa.repository.JpaRepository;
 
-public interface NoticeRepository extends JpaRepository<Announcement, Long> {
+public interface NoticeRepository extends JpaRepository<Notice, Long> {
 
     boolean existsByIdGreaterThan(Long lastNoticeId);
 

diff --git a/...end/streetdrop-api/src/test/java/unit/domains/notice/controller/NoticeControllerTest.java b/...end/streetdrop-api/src/test/java/unit/domains/notice/controller/NoticeControllerTest.java
@@ -1,6 +1,6 @@
 package unit.domains.notice.controller;
 
-import com.depromeet.announcement.Announcement;
+import com.depromeet.notice.Notice;
 import com.depromeet.common.dto.MetaInterface;
 import com.depromeet.common.dto.PageMetaResponseDto;
 import com.depromeet.common.dto.PaginationResponseDto;
@@ -76,8 +76,8 @@ void getNoticesTestSuccess1() throws Exception {
             @Test
             void getNoticesTestSuccess2() throws Exception {
                 var noticeResponseDto = List.of(
-                        new NoticeListResponseDto(new Announcement("Title 1", "Content 1")),
-                        new NoticeListResponseDto(new Announcement("Title 2", "Content 2"))
+                        new NoticeListResponseDto(new Notice("Title 1", "Content 1")),
+                        new NoticeListResponseDto(new Notice("Title 2", "Content 2"))
                 );
                 var meta = PageMetaResponseDto.builder()
                         .page(0)
@@ -109,7 +109,7 @@ class Success {
             @Test
             void getNoticeTestSuccess1() throws Exception {
                 var noticeId = 1L;
-                var noticeResponseDto = new NoticeResponseDto(new Announcement("Title 1", "Content 1"));
+                var noticeResponseDto = new NoticeResponseDto(new Notice("Title 1", "Content 1"));
                 when(noticeService.getNotice(noticeId)).thenReturn(noticeResponseDto);
 
                 var response = mvc.perform(get("/notices/{noticeId}", noticeId));

diff --git a/backend/streetdrop-api/src/test/java/unit/domains/notice/service/NoticeServiceTest.java b/backend/streetdrop-api/src/test/java/unit/domains/notice/service/NoticeServiceTest.java
@@ -1,6 +1,6 @@
 package unit.domains.notice.service;
 
-import com.depromeet.announcement.Announcement;
+import com.depromeet.notice.Notice;
 import com.depromeet.common.error.exception.internal.NotFoundException;
 import com.depromeet.domains.notice.dto.response.NoticeListResponseDto;
 import com.depromeet.domains.notice.dto.response.NoticeResponseDto;
@@ -51,9 +51,9 @@ void getNoticesTestSuccess1() {
             @DisplayName("공지사항 2개 조회")
             @Test
             void getNoticesTestSuccess2() {
-                List<Announcement> notices = List.of(
-                        new Announcement("Title 1", "Content 1"),
-                        new Announcement("Title 2", "Content 2")
+                List<Notice> notices = List.of(
+                        new Notice("Title 1", "Content 1"),
+                        new Notice("Title 2", "Content 2")
                 );
                 when(noticeRepository.findAll()).thenReturn(notices);
 
@@ -78,7 +78,7 @@ class Success {
             @DisplayName("id가 일치하는 경우")
             @Test
             void getNoticeTestSuccess1() {
-                var notice = new Announcement("Title 1", "Content 1");
+                var notice = new Notice("Title 1", "Content 1");
                 when(noticeRepository.findById(1L)).thenReturn(Optional.of(notice));
 
                 var result = noticeService.getNotice(1L);

diff --git a/.../depromeet/announcement/Announcement.java → ...ain/java/com/depromeet/notice/Notice.java b/.../depromeet/announcement/Announcement.java → ...ain/java/com/depromeet/notice/Notice.java
@@ -1,4 +1,4 @@
-package com.depromeet.announcement;
+package com.depromeet.notice;
 
 import static lombok.AccessLevel.PROTECTED;
 
@@ -15,11 +15,11 @@
 @Getter
 @NoArgsConstructor(access = PROTECTED)
 @Entity
-public class Announcement extends BaseTimeEntity {
+public class Notice extends BaseTimeEntity {
 
     @Id
     @GeneratedValue(strategy = GenerationType.IDENTITY)
-    @Column(name = "announcement_id")
+    @Column(name = "notice_id")
     private Long id;
 
     @Column(nullable = false, length = 200)
@@ -29,7 +29,7 @@ public class Announcement extends BaseTimeEntity {
     private String content;
 
     @Builder
-    public Announcement(String title, String content) {
+    public Notice(String title, String content) {
         this.title = title;
         this.content = content;
     }

diff --git a/...domain/src/main/resources/db/migration/V20240702__rename_table_announcement_to_notice.sql b/...domain/src/main/resources/db/migration/V20240702__rename_table_announcement_to_notice.sql
@@ -0,0 +1,2 @@
+ALTER TABLE announcement RENAME notice;
+ALTER TABLE notice CHANGE announcement_id notice_id BIGINT NOT NULL AUTO_INCREMENT;
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		ALTER TABLE announcement RENAME notice;
		ALTER TABLE notice CHANGE announcement_id notice_id BIGINT NOT NULL AUTO_INCREMENT;