-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First attempt at a document on idempotency #3462
Conversation
docs/developer-docs/smart-contracts/best-practices/idempotency.mdx
Outdated
Show resolved
Hide resolved
docs/developer-docs/smart-contracts/best-practices/idempotency.mdx
Outdated
Show resolved
Hide resolved
docs/developer-docs/smart-contracts/best-practices/idempotency.mdx
Outdated
Show resolved
Hide resolved
docs/developer-docs/smart-contracts/best-practices/idempotency.mdx
Outdated
Show resolved
Hide resolved
docs/developer-docs/smart-contracts/best-practices/idempotency.mdx
Outdated
Show resolved
Hide resolved
docs/developer-docs/smart-contracts/best-practices/idempotency.mdx
Outdated
Show resolved
Hide resolved
docs/developer-docs/smart-contracts/best-practices/idempotency.mdx
Outdated
Show resolved
Hide resolved
docs/developer-docs/smart-contracts/best-practices/idempotency.mdx
Outdated
Show resolved
Hide resolved
docs/developer-docs/smart-contracts/best-practices/idempotency.mdx
Outdated
Show resolved
Hide resolved
docs/developer-docs/smart-contracts/best-practices/idempotency.mdx
Outdated
Show resolved
Hide resolved
docs/developer-docs/smart-contracts/best-practices/idempotency.mdx
Outdated
Show resolved
Hide resolved
docs/developer-docs/smart-contracts/best-practices/idempotency.mdx
Outdated
Show resolved
Hide resolved
docs/developer-docs/smart-contracts/best-practices/idempotency.mdx
Outdated
Show resolved
Hide resolved
docs/developer-docs/smart-contracts/best-practices/idempotency.mdx
Outdated
Show resolved
Hide resolved
docs/developer-docs/smart-contracts/best-practices/idempotency.mdx
Outdated
Show resolved
Hide resolved
docs/developer-docs/smart-contracts/best-practices/idempotency.mdx
Outdated
Show resolved
Hide resolved
docs/developer-docs/smart-contracts/best-practices/idempotency.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. LGTM.
docs/developer-docs/smart-contracts/best-practices/idempotency.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @oggy-dfin , thanks a lot for putting in the work!
Really like the explicit listing of advantages and disadvantages for the sequence numbers and deduplication approaches. This makes it much clearer.
Approving, left a few mostly minor comments / questions below.
docs/developer-docs/smart-contracts/best-practices/idempotency.mdx
Outdated
Show resolved
Hide resolved
docs/developer-docs/smart-contracts/best-practices/idempotency.mdx
Outdated
Show resolved
Hide resolved
docs/developer-docs/smart-contracts/best-practices/idempotency.mdx
Outdated
Show resolved
Hide resolved
docs/developer-docs/smart-contracts/best-practices/idempotency.mdx
Outdated
Show resolved
Hide resolved
docs/developer-docs/smart-contracts/best-practices/idempotency.mdx
Outdated
Show resolved
Hide resolved
docs/developer-docs/smart-contracts/best-practices/idempotency.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Jessie Mongeon <133128541+jessiemongeon1@users.noreply.github.com>
Co-authored-by: Jessie Mongeon <133128541+jessiemongeon1@users.noreply.github.com> Co-authored-by: Roel Storms <roel.storms@gmail.com> Co-authored-by: Alin Sinpalean <58422065+alin-at-dfinity@users.noreply.github.com>
Co-authored-by: Jessie Mongeon <133128541+jessiemongeon1@users.noreply.github.com> Co-authored-by: Robin Künzler <60650552+robin-kunzler@users.noreply.github.com> Co-authored-by: Roel Storms <roel.storms@gmail.com>
Co-authored-by: Jessie Mongeon <133128541+jessiemongeon1@users.noreply.github.com>
Co-authored-by: Roel Storms <roel.storms@gmail.com> Co-authored-by: Jessie Mongeon <133128541+jessiemongeon1@users.noreply.github.com>
Co-authored-by: Jessie Mongeon <133128541+jessiemongeon1@users.noreply.github.com>
Thank you for your contribution to the IC Developer Portal. This repo contains the content for https://internetcomputer.org and the ICP Developer Documentation, https://internetcomputer.org/docs/.
If you are submitting a Pull Request for adding or changing content on the ICP Developer Documentation, please make sure that your contribution meets the following requirements:
.mdx
file format to support the previous two components./sidebars.js
, otherwise, it will not appear in theside navigation bar.
.github/CODEOWNERS
file isfilled with new documents that you added. This way we can ensure that future Pull Requests are reviewed by the right people.