Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(IDX): introduce integration tests #92

Merged
merged 12 commits into from
Dec 16, 2024
Merged

Conversation

cgundy
Copy link
Member

@cgundy cgundy commented Dec 16, 2024

Up until now I have only used unit tests and mocked the github responses. This PR introduces integration tests that use a real github token to make calls to a test repository, here: https://github.com/dfinity/test-compliant-repository-public

The benefits include:

  • easier to catch permissions issues
  • easier to refactor code
  • easier to upgrade github3 package and be made aware of any breaking changes

@cgundy cgundy marked this pull request as ready for review December 16, 2024 13:33
@cgundy cgundy requested a review from a team as a code owner December 16, 2024 13:33
@cgundy cgundy merged commit 63edbc8 into main Dec 16, 2024
6 checks passed
@cgundy cgundy deleted the introduce-cla-integration-tests branch December 16, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants