Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update non-working example in more-data section #377

Merged

Conversation

rshmhrj
Copy link
Contributor

@rshmhrj rshmhrj commented Dec 28, 2021

Going through the tour, I got stuck for at least 2-3 hours trying to get this query (expanding and seeing all of the starring in a movie) to work. Ended up dropping data, reimporting, and trying many schema tweaks many times.

I think either updating this section, or pre-filling the full, correct query would be very helpful and allow an easier transition for new users and learners.

Two versions of the full query are below:

{
  kathryn(func: eq(name@., "Kathryn Bigelow")) {
    uid
    name@.
    director.film (first: 1) {
      name@.
      initial_release_date
      genre { name@. }
      starring { 
        uid
        performance.film { name@. }
        performance.actor {
          name@.
        }
        performance.character {
          name@.
        }
      }
    }
  }
}
{
  kathryn(func: eq(name@., "Kathryn Bigelow")) {
    uid
    name@.
    director.film (first: 1) {
      name@.
      initial_release_date
      genre { name@. }
      starring { 
        expand(Performance) {
            uid
            expand(_all_)
        }
      }
    }
  }
}

This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Dec 28, 2021

CLA assistant check
All committers have signed the CLA.

@rshmhrj
Copy link
Contributor Author

rshmhrj commented Feb 8, 2022

@MichelDiz can you please review and merge this minor change in?

@MichelDiz
Copy link
Contributor

@rshmhrj sorry, I can't. I have no rights to do so. And right now I have no idea who have.

Copy link

This PR has been stale for 60 days and will be closed automatically in 7 days. Comment to keep it open.

@github-actions github-actions bot added the Stale label Jul 12, 2024
@rshmhrj
Copy link
Contributor Author

rshmhrj commented Jul 17, 2024

Can this be merged in?

@github-actions github-actions bot removed the Stale label Jul 18, 2024
@ryanfoxtyler ryanfoxtyler merged commit 8006871 into dgraph-io:master Jul 18, 2024
2 checks passed
@rshmhrj rshmhrj deleted the rshmhrj-more-data-example-query-update branch July 19, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants