Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve code style in analytics #19592

Merged
merged 7 commits into from
Jan 6, 2025
Merged

chore: Improve code style in analytics #19592

merged 7 commits into from
Jan 6, 2025

Conversation

larshelge
Copy link
Member

No description provided.

@larshelge larshelge changed the title chore: Fix code style chore: Improve code style in analytics Jan 4, 2025
Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.31%. Comparing base (6cb0d1f) to head (5be87f6).
Report is 12 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #19592       +/-   ##
=============================================
+ Coverage     31.63%   67.31%   +35.67%     
- Complexity      457      640      +183     
=============================================
  Files          3482     3477        -5     
  Lines        126064   125996       -68     
  Branches      14176    14162       -14     
=============================================
+ Hits          39884    84808    +44924     
+ Misses        82835    34758    -48077     
- Partials       3345     6430     +3085     
Flag Coverage Δ
integration 48.65% <ø> (?)
integration-h2 35.15% <ø> (?)
unit 31.59% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...is/analytics/event/data/EventAggregateService.java 19.78% <ø> (+17.58%) ⬆️
...p/dhis/analytics/event/data/EventQueryService.java 70.19% <ø> (+3.84%) ⬆️

... and 2057 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 584c870...5be87f6. Read the comment docs.

@larshelge larshelge merged commit 52ca7f1 into master Jan 6, 2025
17 checks passed
@larshelge larshelge deleted the lars-dev branch January 6, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant