cs and cf with default comparison. A way to add default values in the modifier class.

[parnas]

Modifier.js now calls the ensureParameters function during run, which checks if there is a defaults function in the current modifier. And processes it in the "variable name: variable value" loop.

Additionally, in ComparisonModifier.js there is an additional simplification for the classes that extend it, and that only have default compare point definition (which is the only use case at the moment):

  defaultComparePoint(_context) {
    return ['=', _context.min];
  }

Additionally (or, rather, this is how it is started), I've added default values to Critical Success and Critical Failure modifiers. So now it is possible to do just 1d20cscf (instead of 1d20cs=20cf=1).

No tests yet, but, of course, I'll add them if the approach gets approved.

[GreenImp]

I really like this, thanks! A much better way of handling it than what I was doing. Thanks for this 😄

I've left a few minor comments. And another thing is just to make sure that the doc block descriptions describe the what the methods do, as they're used to auto-generate the API docs.

[parnas]

@GreenImp Updated and added tests. Let me know, if you'll spot anything else.

[GreenImp]

Looks great! Thanks so much for working on this

[GreenImp]

@parnas this has just gone out in v5.5.0. Thanks for you help 😃

The API docs have been updated, but the notation sections haven't yet.
Also, the roller in the docs is still currently using the older version, so you'll have to specify the compare point in the docs for now.

The docs have been updated, and the inbuilt roller should also be working without compare points for cs and cf modifiers.