-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sara A Airport Challenge #177
Open
SaraAGithub-Portfolio
wants to merge
39
commits into
digital-futures-academy:main
Choose a base branch
from
SaraAGithub-Portfolio:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Sara A Airport Challenge #177
SaraAGithub-Portfolio
wants to merge
39
commits into
digital-futures-academy:main
from
SaraAGithub-Portfolio:main
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iles to specs folder
…ith module.exports
…ane to land. Wrote failing test. Wrote passing test.
…s plane parameter; method returns true/false to show successful landing.
…n and renaming it as airportDestination to be specific
…ed to see if plane is at airport with plane.isAtAirport
… Proceeded to run passing test after failed.
…ng test, then passing test for Test 4 Airport Spec.
… testing requirements.
…code performs various operations using the functions seen in the file.
…nal more organized.
…od checks if the lcoation property of the plane object is equal to airport and returns true if it matches.
…ed capacity value to smmaler number.
…test(after it failed, then passed) to test if planes already flying cannot take off nor be at the airport.
…ile paths in require statements.
…portCapacity -> defaultAirportCapacity to be more concise. Changed setMax to updateCapacity taking a parameter of newCapacity to indicate the overridden value. Changed capacity to smaller number.The logic in the land function and takeOff function has changed and the isFull function has been removed.
… test to see if a plane is flying or not.The logic for the isAtAirport function has been updated slightly.
…tions, and when run will output if a plane can be landed, the airport's capacity and other operations. A new plane instance was created to further test the functionality of the airport module.
…o run tests, and how to install.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt to submit a pull request for the Airport Challenge.