-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kee Wei Airport Challenge #182
Open
Saphly
wants to merge
13
commits into
digital-futures-academy:main
Choose a base branch
from
Saphly:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saphly
commented
Jun 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like:
- Group tests together by their situation, e.g. "When constructing an airport". This makes is feels more like a story and its easier for me to keep track.
- Used switch case for checking the weather so that it would be easier to add another weather type if needed.
- Classes are loosely coupled
Could have done better:
- Have a better structured domain model. See how they all connect.
- Have error handling instead of making the code do nothing or return nothing
- to not test implementation details. e.g this.listOfPlanes.length.
- After refactoring the code, go back and look at the test suite and see what could be changed.
e.g. when landing a plane, should check that the object is actually a plane: could have used canLand() to check
Things to try to do to improve in next challenege:
- Write out domain models for everything. Review it at the end to have a better feel on how they will interact/connect to each other.
- Implement error handling
- Enforce TDD
- Make tests to be loosely coupled by using mock classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.