Blé Mardel Airport Challenge #196
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mardeldev
commented
Jun 21, 2023
| class Instruction { | ||
|
|
||
| } | ||
| export default Instruction; |
There was a problem hiding this comment.
What went well:
- I think that I have done a good job of following TDD principles, by first writing failing tests, then writing production code to pass the tests.
- With the use of the Instruction class, I was able to loosely couple my code and maintain high cohesiveness. This was done by using the instruction class that took in an airport, and plane object...and only having the relevant methods written in the relevant classes. For example, the instruction class simply calls on the airport's
landPlane()method. It doesn't handle the landing of the planes itself.
mardeldev
commented
Jun 21, 2023
| expect(() => { testInstruction.landPlane() }).toThrowError('Too stormy to land / take-off'); | ||
| }) | ||
| }) | ||
| }) |
There was a problem hiding this comment.
What went well:
- With the use of Jasmine as my testing framework, I was able to advance from simple assertion tests. I was also able to test whether the correct methods were called, and also test my error-handling procedures.
mardeldev
commented
Jun 21, 2023
| this.#airport.landPlane(this.#plane); | ||
| } | ||
|
|
||
| takeOffPlane() { | ||
| if (this.#plane.isLanded() === false) { | ||
| throw this.#takeOffError; | ||
| } | ||
| if (this.#airport.checkWeather() === 'stormy') { | ||
| throw this.#weatherError; | ||
| } |
There was a problem hiding this comment.
Even Better If:
- I could have used a method to handle the logic of checking for errors, instead of having them within the methods that should only be doing one thing e.g. landing or take-off a plane. This would make my code look cleaner, and it would be easier to maintain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.