Switch to the new insights API endpoint

digma-ai · Jun 12, 2023 · a6cc42d · a6cc42d
1 parent 7e1a80a
commit a6cc42d
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 16 deletions.
diff --git a/backend/analyticsProvider.js b/backend/analyticsProvider.js
@@ -37,14 +37,14 @@ class AnalyticsProvider {
     }
   }
 
-  async getInsights(codeObjectIds, environment) {
+  async getInsights(spanCodeObjectId, environment) {
     try {
       const response = await this.send(
         "POST",
-        `/CodeAnalytics/codeObjects/insights`,
+        `/CodeAnalytics/codeObjects/insights_of_single`,
         undefined,
         {
-          codeObjectIds,
+          spanCodeObjectId,
           environment,
         }
       );

diff --git a/backend/server.js b/backend/server.js
@@ -34,7 +34,7 @@ app.post("/environments/:environmentId/assets", async function (req, res) {
 app.post("/insights", async function (req, res) {
   try {
     const insights = await analyticsProvider.getInsights(
-      req.body.codeObjectIds,
+      req.body.spanCodeObjectId,
       req.body.environment
     );
     res.send(insights);

diff --git a/ui/src/components/Assets/AssetInsights/index.tsx b/ui/src/components/Assets/AssetInsights/index.tsx
@@ -46,6 +46,7 @@ import {
 import {
   AssetInsightsProps,
   CodeObjectInsight,
+  GetInsightsResponse,
   InsightGroup,
   SpanInsight,
 } from "./types";
@@ -214,11 +215,7 @@ export const AssetInsights = (props: AssetInsightsProps) => {
 
   const assetTypeInfo = getAssetTypeInfo(props.assetEntry.assetType);
 
-  const codeObjectIds = [props.assetEntry.span.spanCodeObjectId];
-
-  if (props.assetEntry.span.methodCodeObjectId) {
-    codeObjectIds.push(`method:${props.assetEntry.span.methodCodeObjectId}`);
-  }
+  const spanCodeObjectId = props.assetEntry.span.spanCodeObjectId;
 
   const handleAssetsLinkClick = () => {
     props.onGoToAssetsPage(props.assetEntry);
@@ -229,19 +226,17 @@ export const AssetInsights = (props: AssetInsightsProps) => {
   };
 
   const fetchInsights = async () => {
-    const insights = (await ddClient.extension.vm?.service?.post("/insights", {
-      codeObjectIds,
+    const response = (await ddClient.extension.vm?.service?.post("/insights", {
+      spanCodeObjectId,
       environment: props.environment,
-    })) as CodeObjectInsight[];
+    })) as GetInsightsResponse;
 
     console.debug(
-      `Insights for asset with ids [${codeObjectIds
-        .map((x) => `"${x}"`)
-        .join(", ")}] have been fetched:`,
+      `Insights for asset with id "${spanCodeObjectId}" have been fetched:`,
       insights
     );
 
-    const sortedInsights = [...insights].sort(
+    const sortedInsights = [...response.insights].sort(
       (a, b) =>
         getInsightTypeOrderPriority(a.type) -
         getInsightTypeOrderPriority(b.type)

diff --git a/ui/src/components/Assets/AssetInsights/types.ts b/ui/src/components/Assets/AssetInsights/types.ts
@@ -24,6 +24,13 @@ export interface InsightWithLinksProps {
   onAssetSelect: (asset: ExtendedAssetEntry) => void;
 }
 
+export interface GetInsightsResponse {
+  accountId: string;
+  environment: string;
+  spanCodeObjectId: string;
+  insights: CodeObjectInsight[];
+}
+
 export interface InsightGroup {
   insights: CodeObjectInsight[];
   name?: string;