Skip to content

Commit

Permalink
Add validation step to CI (#90)
Browse files Browse the repository at this point in the history
  • Loading branch information
shaykeren authored Nov 15, 2023
2 parents 261066b + dafeefe commit f951fdd
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 1 deletion.
18 changes: 18 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,3 +76,21 @@ jobs:
platforms: linux/amd64,linux/arm64
push: ${{ github.event_name != 'pull_request' }}
tags: ${{ steps.metadata.outputs.tags }}

validate:
name: Validate
needs: [build-and-push]
runs-on: ubuntu-latest-m

steps:
- name: Extract image tag
run: |
TAG=${{ github.event.release.tag_name }}
echo "TAG=${TAG#v}" >> $GITHUB_ENV
- name: Set up Docker Desktop
id: start_desktop
uses: docker/desktop-action/start@v0.3.1

- name: Validate extension
run: docker extension validate digmaai/digma-docker-extension:${TAG}
2 changes: 1 addition & 1 deletion backend/server.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const { AnalyticsProvider } = require("./analyticsProvider");
var app = express();
app.use(express.json());

var analyticsProvider = new AnalyticsProvider("https://digma-compound:5051");
var analyticsProvider = new AnalyticsProvider(process.env.PLUGIN_API_URL);

app.get("/environments", async function (req, res) {
try {
Expand Down
2 changes: 2 additions & 0 deletions docker-compose.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
services:
my-extension:
image: ${DESKTOP_PLUGIN_IMAGE}
environment:
- PLUGIN_API_URL=https://${PLUGIN_API_URL:-digma-compound}:5051

nginx:
image: digmaai/jaeger-ui:1.29.1-digma.0.1.4
Expand Down

0 comments on commit f951fdd

Please sign in to comment.