feat: Implemented HLS stream source as new plugin type. #84
Conversation
Also implemented show_controls and autoplay attributes on the video element. These are particularly useful when showing a live stream.
sepi
force-pushed
the
hls-stream-source
branch
from
605e6ad to
b83f60b
Compare
sepi
changed the title
| {% endif %} | ||
|
|
||
| {% addtoblock "js" %} | ||
| <script src="https://cdn.jsdelivr.net/npm/hls.js@1.5.17/dist/hls.min.js "></script> |
There was a problem hiding this comment.
There is an extra space here after the hls.min.js.
djangocms_video/models.py
Outdated
| """ | ||
| Renders the HTML <source> element inside of <video> for an HLS stream defined by a .m3u8 URL. | ||
| """ | ||
| hls_source_url = models.CharField( |
There was a problem hiding this comment.
| hls_source_url = models.CharField( | |
| hls_source_url = models.URLField( |
Should this be a URLField? Can the max_length fall back to Django's default?
| hls.loadSource(hlsUrl); | ||
| hls.attachMedia(video); | ||
| hls.on(Hls.Events.MANIFEST_PARSED, function (event, data) { | ||
| console.log('manifest loaded, found ' + data.levels.length + ' quality level',); |
There was a problem hiding this comment.
| console.log('manifest loaded, found ' + data.levels.length + ' quality level',); |
Is this left over from debugging?
| {% endif %} | ||
|
|
||
| {% addtoblock "js" %} | ||
| <script src="https://cdn.jsdelivr.net/npm/hls.js@1.5.17/dist/hls.min.js "></script> |
There was a problem hiding this comment.
Could that source be configurable and default to the cdn? Alternatively, please add a comment to the README on how to overwrite this template.
|
@sepi Would be great if you can address these review comments so that we can work together quickly to get this merged. |
|
I reacted to all of your comments except for the tests. I don't really see any functionality I could test correctly. Maybe I also don't believe in tests or am just lazy :P |
|
@vinitkumar @sepi To me, it seems, there's just a few small things ti fix:
|
|
@sepi I had a look, and the change of I made some updates to fix the migrations, superfluous spaces in the template and the test setup. (For some reason, I cannot compile the python 3.9 requirements on my machine - that can be fixed separately.) PS: The existing tests revealed that your change to the video player template added unnecessary spaces... |
Also implemented show_controls and autoplay attributes on the video element. These are particularly useful when showing a live stream.
Description
In order to be able to show an rtsp live stream, an HLS video source is implemented using HLS.js. The script is currently embedded using a CDN.
In order to stream rtsp to the web, you first need to make an .m3u8 playlist file available using for example ffmpeg. The URL of this file can be used as URL of the stream source.
Related resources
Checklist
masterSlack to find a “pr review buddy” who is going to review my pull request.