Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RG35XX+ support #96

Closed
wants to merge 6 commits into from
Closed

Conversation

igavrilov
Copy link

@igavrilov igavrilov commented Aug 12, 2024

I tried the RG35XX OG build on my RG35XX+ console but wasn't able to run it due to the issue described in this Reddit comment. It seems that the toolchain for the OG version is not compatible with the Plus version.

So, I built the app using the union-rg35xxplus-toolchain, and it works well so far. Special thanks to @emartinez-dev for publishing his solution. I made a few changes:

  • Switched the toolchain (the build with union-rg35xx-toolchain works, but it stutters after some time)
  • Renamed "H" to "PLUS"
  • Added a muOS shell script and a how-to guide

@djdiskmachine
Copy link
Owner

Thanks for the contribution and the descriptive solution!
I'll have another look at this this evening. =)

@djdiskmachine
Copy link
Owner

Hello! Sorry for the delayed response.
I've reviewed your changes and how they relate to the following PR:
#95

I will prioritize the changes in the Makefiles from pull 95 and your documentation and resource contributions.
I hope you find this fair. :)
Great job! Thanks a lot for helping to keep Little Piggy Tracker stay relevant! =3

@igavrilov
Copy link
Author

Hey! It's absolutely fair, anyway I will respect your any decision since you're the maintainer :)
Looked at the #95, didn't expect plush file there.


There is definitely a problem with the build on RG35XX plus device as I explained here. With higher BPMs (175 and above) it starts stuttering, however it works totally fine at 128-ish (which is way more better in comparison to RPi builds). I don't see this problem with my pocketCHIP device at all so it must be something specific to Anbernic. Unfortunately I don't own other devices so I can not test on H/S/24/OG this behaviour. When I find some spare time I'll try to build #95 to check if the issue still persist, otherwise I'll try to debug, it may take some time though. I'll keep you posted.

@simotek
Copy link

simotek commented Aug 19, 2024

@djdiskmachine I'm in the process of merging this into #95 how do you feel about using GARLICPLUS for the naming of this one and GARLIC for what is currently RG35XX? Then using RG35XX and RG35XXPLUS for the images designed for the Stock OS?

Both GARLIC versions require SDL1.2 where as the Stock OS requires SDL2, The rg35xx-plus stock image is now also 64bit (aarch64-linux-gnu) while the rg35xx uses 32bit (arm-linux-gnueabihf). If we build with the right compile options then we probably shouldn't need separate builds for GARLIC and GARLICPLUS as the OS should be very similar if not the same, unless some compiler optimizations make a significant difference.

From talking to people on the rg35xx-plus discord I suspect that most rg35xx-plus/h users will wind up on the Stock or a Customized Stock Rom because the performance is better, similarly i'm not going to try and build a image for the stock os on the rg35xx unless someone is willing to test it, so we might be able to drop back to 2 images at some point.

@djdiskmachine
Copy link
Owner

@djdiskmachine I'm in the process of merging this into #95 how do you feel about using GARLICPLUS for the naming of this one and GARLIC for what is currently RG35XX? Then using RG35XX and RG35XXPLUS for the images designed for the Stock OS?

I think this is a good idea!
Just add a line about it in the build readme :)

@purelygrey
Copy link

purelygrey commented Aug 26, 2024

Hey, just my two cents, Garlic is not really a thing on all of the H700-based devices, so I find the naming pretty confusing, I'd call anything H700 related H700, since there are also 28XX and 40XX devices in the lineup now. MuOS calls their builds 35XX-SPLUSH, but there's also a RG40XX V device now, annoying. I'd rather just have H700 if there's no need for specific patches for 28xx due to rotated screen and whatnot

I guess that doesn't really matter but I personally find stock firmware just about awful and I never use it :-D

Great job!

@djdiskmachine
Copy link
Owner

Included in #95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants