This repository has been archived by the owner on Aug 12, 2024. It is now read-only.
Basic Support for Docker Machine #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 3, 2016 13:48
- Refactor proxy and setup to single `dockercraft` daemon - Automatically download the latest Docker release, remove the Docker binary from the repo - Use Golang 1.6 - Update to Docker 1.11.1 in the Dockerfile - Dockerize all the testing - Add test targets for checking our golang code - Build and Serve targets for testing changes - Address comments from go fmt and go lint - Add simple circle.yml for CircleCI Signed-off-by: Dave Tucker <dt@docker.com>
Signed-off-by: Dave Tucker <dt@docker.com>
|
Obligatory GIF demo |
|
The shakiness on switching worlds is due to Cuberite getting a list of containers when the player has changed worlds. This can go away once the aforementioned race is fixed as each world will continue to update in the background (i.e with no player logged in) |
|
wow |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic support for Docker Machine
As Cuberite doesn't (yet) support dynamic reload of
settings.ini, the machines that are available when Dockercraft is started are the only ones available...We mount the users
~/.docker/machine/machinesfolder, iterate over it, find machines with an IP address and have a go at connecting to them. This is tested to work with Docker Machine 0.7.0Full usage is covered in the README but the TL;DR is
/worldsto see available worlds and/portal <world>to change worlds.This work has exposed a race between the when the proxy is ready to send events and when the Docker plugin is ready to receive them. Hopefully this will be improved by #42
Depends On #59
Closes #49