Refactor and improve audio system #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix potential uninitialized variable issue in `oslDecodeWav` by initializing `streambuffer` to NULL and checking before freeing it. - Add null checks and improve error handling in `oslAudioCallback_PlaySound_WAV`, `oslAudioCallback_AudioCallback_WAV`, `oslAudioCallback_ReactiveSound_WAV`, and `oslAudioCallback_StandBy_WAV`. - Improve `oslAudioCallback_DeleteSound_WAV` with added null safety and proper memory management. - Refactor `oslLoadSoundFileWAV` for better error handling, memory safety, and readability, including consolidated error handling and memory deallocation in case of failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oslDecodeWavby initializingstreambufferto NULL and checking before freeing it.oslAudioCallback_PlaySound_WAV,oslAudioCallback_AudioCallback_WAV,oslAudioCallback_ReactiveSound_WAV, andoslAudioCallback_StandBy_WAV.oslAudioCallback_DeleteSound_WAVwith added null safety and proper memory management.oslLoadSoundFileWAVfor better error handling, memory safety, and readability, including consolidated error handling and memory deallocation in case of failure.