feat: Fix auth error, errors out properly closes #450 and increased l…

…og level for silent resource failures Signed-off-by: dark0dave <dark0dave@mykolab.com>
doitintl · Sep 5, 2023 · fcafd01 · fcafd01
1 parent f6ebd85
commit fcafd01
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/cmd/kubent/main.go b/cmd/kubent/main.go
@@ -36,16 +36,19 @@ func generateUserAgent() string {
 	return fmt.Sprintf("kubent (%s/%s)", version, gitSha)
 }
 
-func getCollectors(collectors []collector.Collector) []map[string]interface{} {
+func getCollectors(collectors []collector.Collector, exitIfError bool) []map[string]interface{} {
 	var inputs []map[string]interface{}
 	for _, c := range collectors {
 		rs, err := c.Get()
 		if err != nil {
 			log.Error().Err(err).Str("name", c.Name()).Msg("Failed to retrieve data from collector")
-		} else {
-			inputs = append(inputs, rs...)
-			log.Info().Str("name", c.Name()).Msgf("Retrieved %d resources from collector", len(rs))
+			if exitIfError {
+				os.Exit(EXIT_CODE_FAIL_GENERIC)
+			}
+			continue
 		}
+		inputs = append(inputs, rs...)
+		log.Info().Str("name", c.Name()).Msgf("Retrieved %d resources from collector", len(rs))
 	}
 	return inputs
 }

diff --git a/pkg/collector/cluster.go b/pkg/collector/cluster.go
@@ -121,7 +121,7 @@ func (c *ClusterCollector) Get() ([]map[string]interface{}, error) {
 		log.Debug().Msgf("Retrieving: %s.%s.%s", g.Resource, g.Version, g.Group)
 		rs, err := ri.List(context.Background(), metav1.ListOptions{})
 		if err != nil {
-			log.Debug().Msgf("Failed to retrieve: %s: %s", g, err)
+			log.Warn().Msgf("Failed to retrieve: %s: %s", g, err)
 			continue
 		}