This repository has been archived by the owner on Jan 6, 2021. It is now read-only.
Links #70
Open
Links #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@VinaiRachakonda UI changes made! |
casey-chow
reviewed
Apr 26, 2019
| @@ -55,6 +55,15 @@ export interface CompanyLink { | |||
| url?: string; | |||
| } | |||
|
|
|||
| export const companyLinkSchema = { | |||
casey-chow
reviewed
Apr 26, 2019
| import { | ||
| withAC, | ||
| ApplicationContainerProps, | ||
| } from '../../containers/ApplicationContainer'; | ||
| import Comment from './Comment'; | ||
| import CommentForm from './CommentForm'; | ||
|
|
||
| const CommentSectionWrapper = styled.div` | ||
| margin-top: 15%; |
There was a problem hiding this comment.
Any reason this is a %? This may get unpredictable. @albertzhidong
There was a problem hiding this comment.
nah we can switch to 15vh -- will do
There was a problem hiding this comment.
Mm still not a fan--can we move to ems? It doesn't really make sense to have the padding be a function of vertical space on screen since we scroll vertically imo
client/components/CompanyProfile/LinksViewer/LinksViewerDisplay.tsx
Outdated
Show resolved
Hide resolved
|
This is how it looks for me now. Is this the intent?
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds links and attachment dropdown to company links page