Fix docs file names and add validation #107334
Conversation
dotnet-issue-labeler
bot
added
the
needs-area-label
ericstj
added
area-Infrastructure-libraries
and removed
needs-area-label
| </ItemGroup> | ||
|
|
||
| <Error Text="The shared framework files '@(_missingSharedFrameworkFile)' were missing." Condition="'@(_missingSharedFrameworkFile)' != ''" /> | ||
| </Target> |
There was a problem hiding this comment.
I am a big fan of the addition of tests for infra stuff, thank you.
Question: Do you know why the re are some _missingSharedFrameworkFile items with the name ''?
There was a problem hiding this comment.
Question: Do you know why the re are some _missingSharedFrameworkFile items with the name ''?
The condition '@(_missingSharedFrameworkFile)' != '' means _the item named missingSharedFrameworkFile is not empty. It's used to ensure we don't raise the error when no files are missing.
|
/ba-g The two tvos-arm64 and ios-arm64 failures are known and pre-existing. There was an issue tracking the failure but the json text was too limited. I just adjusted it. #103692 |
|
/backport to release/9.0 |
|
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10704907884 |
Fix #106825
The build process does not rename doc files when copying to output. See issue for details.
I added a target to the project that was copying these to act as a test case so that this doesn't regress again. It's a bit redundant, but that is what tests are after all - just a different way to state a requirement in a way that's unlikely to regress in the same way as the product.