Use -pack switch instead of -allconfigurations to create packages #110778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
needs-area-label
This was referenced Dec 17, 2024
akoeplinger
reviewed
Dec 17, 2024
| @@ -64,7 +64,7 @@ extends: | |||
| - windows_x64 | |||
| jobParameters: | |||
| templatePath: 'templates-official' | |||
| buildArgs: -s tools+libs -allConfigurations -c $(_BuildConfig) /p:TestAssemblies=false /p:TestPackages=true | |||
| buildArgs: -s tools+libs -allConfigurations -c $(_BuildConfig) /p:BuildAllConfigurations=true /p:TestAssemblies=false /p:TestPackages=true | |||
There was a problem hiding this comment.
why don't we pass -pack here?
There was a problem hiding this comment.
Because libraries packages shouldn't be generated for libraries packages in runtimelab: https://github.com/dotnet/runtime/blame/e65457031da52f57d03da721f381a82a5be64c03/eng/packaging.targets#L31
| @@ -28,7 +27,6 @@ stages: | |||
| # Stages-based publishing entry point | |||
| - template: /eng/common/templates-official/post-build/post-build.yml | |||
| parameters: | |||
| publishingInfraVersion: ${{ parameters.publishingInfraVersion }} | |||
There was a problem hiding this comment.
Yes. The publishing infra version doesn't need to be set anymore. We removed the explicit set from most other repos. I didn't want to open a separate PR just for this.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't do incremental servicing in runtime anymore and hence don't need to rely on the
GeneratePackageOnBuildproperty. Use the-packaction (which implies building all TFMs) instead of-allconfigurations(which implied also creating packages).I need to queue an official build to test this E2E.