Add fixes proposed by Rector

dragomano · Jan 3, 2024 · bf8051e · bf8051e
1 parent b56d108
commit bf8051e
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 11 deletions.
diff --git a/Sources/SimpleModMaker/Builder.php b/Sources/SimpleModMaker/Builder.php
@@ -310,9 +310,6 @@ private function createTables(): void
 
 	private function addScheduledTasks(string &$database): void
 	{
-		if (empty($this->skeleton['scheduled_tasks']))
-			return;
-
 		foreach ($this->skeleton['scheduled_tasks'] as $task) {
 			switch ($task['regularity']) {
 				case 0:

diff --git a/Sources/SimpleModMaker/Handler.php b/Sources/SimpleModMaker/Handler.php
@@ -842,9 +842,6 @@ private function prepareScheduledTasks(array &$tasks, string $baseClassname): vo
 	{
 		global $context;
 
-		if (empty($context['smm_skeleton']['scheduled_tasks']))
-			return;
-
 		foreach ($context['smm_skeleton']['scheduled_tasks'] as $id => $task) {
 			$classname = $this->getCamelName($task['slug']);
 			$filename = $classname . '.php';
@@ -877,9 +874,6 @@ private function prepareBackgroundTasks(array &$tasks, string $baseClassname): v
 	{
 		global $context;
 
-		if (empty($context['smm_skeleton']['background_tasks']))
-			return;
-
 		foreach ($context['smm_skeleton']['background_tasks'] as $id => $task) {
 			$classname = $task['classname'];
 			$filename = $classname . '.php';

diff --git a/Sources/SimpleModMaker/hooks/integrate_daily_maintenance.php b/Sources/SimpleModMaker/hooks/integrate_daily_maintenance.php
@@ -2,7 +2,7 @@
 
 $tasks = '';
 
-foreach ($context['smm_skeleton']['legacy_tasks'] as $id => $task) {
+foreach ($context['smm_skeleton']['legacy_tasks'] as $task) {
 	if (empty($task['regularity'])) {
 		$tasks .= "\$this->{$task['method']};";
 	}

diff --git a/Sources/SimpleModMaker/hooks/integrate_weekly_maintenance.php b/Sources/SimpleModMaker/hooks/integrate_weekly_maintenance.php
@@ -2,7 +2,7 @@
 
 $tasks = '';
 
-foreach ($context['smm_skeleton']['legacy_tasks'] as $id => $task) {
+foreach ($context['smm_skeleton']['legacy_tasks'] as $task) {
 	if (empty($task['regularity']))
 		continue;