Pnpm #1079
Closed
Pnpm #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please consider that we use the boiler-plates (e.g. https://github.com/IT4Change/boilerplate-frontend) and do the package updates via these boiler-plates. May be we run in problems when switching to pnpm or we have to do it in the boiler-plates as well |
mahula
added
devops
refactor
dependencies
1 task
|
Let us discuss switching to Pnpm or Yarn Berry and relations to the boilerplates in one of the next team meetings. |
roschaefer
force-pushed
the
pnpm
branch
2 times, most recently
from
d212b55 to
ea9d565
Compare
Motivation ---------- We have completely different `node --version`s on local development, build server (even in different jobs) and production. My suggestion is that we configure the node version in a central file in the root folder and reference it from everywhere. For me, any version manager is fine. If I have the choice, I suggest [asdf-vm]](https://github.com/asdf-vm/asdf). How to test ----------- 1. Check status checks
Motivation ---------- This PR solves two problems: 1. A custom vagrant box is built for better reproducibility (no more changes during runtime) 1. The code in the vagrant box needs the *local code* so we can actually test out local changes, not the ones pushed to Github. How to test ----------- 1. Follow infrastructure/README.md
Motivation ---------- `pnpm` itself has a number of advantages, two are very relevant for our repository: * De-duplication of node modules * Run commands across packages This will also setup `dotenvx` to read .env files (for unique port numbers). It will also make local development with `docker compose` obsolete for our nodejs projects. How to test ----------- 1. `pnpm install` 2. `pnpm run -r dev` commits: * fix unique ports and environments * fix: extraneous import * remove obsolete `package-lock.json` * run `pnpm install` * run `corepack use pnpm@latest`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
pnpmitself has a number of advantages, two are very relevant for our repository:This will also setup
dotenvxto read .env files (for unique port numbers).It will also make local development with
docker composeobsolete for our nodejs projects.How to test
pnpm installpnpm run -r devcommits:
package-lock.jsonpnpm installcorepack use pnpm@latest