Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend): header design fixes and adaptions for first release #1249

Merged
merged 14 commits into from
Jun 28, 2024
Merged

fix(frontend): header design fixes and adaptions for first release #1249

merged 14 commits into from
Jun 28, 2024

Conversation

Bettelstab
Copy link
Contributor

🍰 Pullrequest

Makes the following changes to the menu:

  • Change the border opacity of the items in dark mode (according to the design drafts)
  • Changes the spacings in UserInfo (according to the design drafts)
  • Removes messages and news, as we don't use them in the first release version
  • Adds tests for MessageIndicator and NewsIndicator, so test coverage does not go down and we can keep those components for later

Issues

@Bettelstab Bettelstab changed the title Header fixes fix(frontend): header design fixes and adaptions for first release Jun 23, 2024
@Bettelstab Bettelstab mentioned this pull request Jun 23, 2024
Open
10 tasks
@Bettelstab
Copy link
Contributor Author

Sorry, but I think one change I made to adjust the UserInfo spacings got lost. Please wait with reviews as I ask @Hardy-Hart-am-Start first if it's alright now.

Elweyn
Elweyn approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@Elweyn Elweyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good on localhost

@Elweyn Elweyn merged commit 02ec34f into master Jun 28, 2024
116 checks passed
@mahula mahula deleted the header-fixes branch July 25, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elweyn Elweyn Elweyn approved these changes

Assignees

@Bettelstab Bettelstab

Labels
None yet
Projects
Dreammall.earth
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bettelstab @Elweyn